Opened 9 years ago

Closed 9 years ago

#1678 closed defect (fixed)

HTTPS Everywhere broken with 4.0b2pre nightly build

Reported by: schoen Owned by: pde
Priority: High Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A user reported that HTTPS Everywhere just doesn't work at all with the most recent Firefox nightly build. (I guess the observed behavior is that no sites are rewritten to HTTPS?)

Child Tickets

Attachments (2)

https_everywhere_preferences_dialog.png (25.7 KB) - added by mstockman 9 years ago.
Screenshot demonstrating the Preferences dialog bug
salty-horse-patch.txt (7.1 KB) - added by nickm 9 years ago.
patch from salty-horse on IRC

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by Tigerchen

broken as well with a 4.0b3pre

comment:2 Changed 9 years ago by pde

Status: newaccepted

I reduce the max Firefox version for the stable branch to 3.9. Anyone wanting to debug this can still install a development branch version.

comment:3 Changed 9 years ago by mstockman

Also, on Firefox 4.0b3 on Mac OS X, with 0.2.2development3 and other recent versions, the Preferences dialog box is empty, and can't be dismissed by the Enable All, Cancel, or OK buttons. Only the Close (red) button on the dialog's title bar dismisses the box.

I'll attach a screenshot after I submit this comment.

Changed 9 years ago by mstockman

Screenshot demonstrating the Preferences dialog bug

comment:4 Changed 9 years ago by misheast

Continues to not work on FF 4.0b5 / Win Vista.

  • No sites are re-written to HTTPS.
  • When choosing the preferences dialog box in the FF add-on manager, clicking on any of the buttons gives no response. Only the 'x' to close button is responsive.

comment:5 Changed 9 years ago by mikeperry

Partial patch at: http://pastebin.com/UFrDjx8M

Courtesy of salty-horse.

Changed 9 years ago by nickm

Attachment: salty-horse-patch.txt added

patch from salty-horse on IRC

comment:6 Changed 9 years ago by nickm

Uploading that patch to the tracker. Pastebin is world-editable, and has a tendency to expire.

comment:7 Changed 9 years ago by mikeperry

comment:8 Changed 9 years ago by mikeperry

Status: acceptedneeds_review

comment:9 Changed 9 years ago by salty-horse

I tested the patch on Firefox 3 and 4, but I didn't test it fully, so some things may break. I'm especially not sure about where I moved the app-startup code.

The addition of <em:unpack> to install.rdf is required because extensions aren't extracted by default.

HTTPS-Everywhere expects the extension to be extracted because it tries to list the contents of the rules/ dir, and access the files using the nsILocalFile interface, which doesn't work with packed XPI's.

If you're interested in using the packed XPI, both the built-in rules and the custom rules could be accessed via XMLHTTPRequest that will fetch them as chrome:// and [ file://] URI's.

comment:10 Changed 9 years ago by Tigerchen

seems to work, but e.g. this tracker leads me to a blank page after clicking "login" and entering my credentials. But after hitting back and reloading the page i was logged in, so it seems to send that information anyway

comment:11 Changed 9 years ago by salty-horse

Tigerchen, there was a problem with following redirects due to yet another changed API. I think I fixed it. Can you try again?

comment:12 Changed 9 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

We merged this in to master. Should appear in 0.2.3 (the next unstable release).

Note: See TracTickets for help on using tickets.