All cryptography unit test coverage should be over 95%; all should have test vectors

It's high, but it's not there yet:

x/crypto.c.gcov 204 738 78.34
x/crypto_curve25519.c.gcov 8 74 90.24
x/crypto_ed25519.c.gcov 17 95 84.82
x/crypto_format.c.gcov 5 95 95.00
x/crypto_pwbox.c.gcov 2 59 96.72
x/crypto_s2k.c.gcov 14 152 91.57
x/aes.c.gcov 0 17 100.00
TOTAL 250 1230 83.11

changed milestone to %Tor: 0.2.9.x-final

added 028-triage TorCoreTeam201605 component::core tor/tor milestone::Tor: 0.2.9.x-final owner::nickm parent::16791 points::3 priority::medium resolution::implemented review-group-1 reviewer::isis severity::normal sponsor::S-can status::closed testing tor-tests-coverage tor-tests-unit type::enhancement labels

Trac:
Milestone: Tor: 0.2.7.x-final to Tor: 0.2.8.x-final

Trac:
Keywords: N/A deleted, 028-triage added

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

Trac:
Sponsor: N/A to SponsorS
Keywords: SponsorS deleted, N/A added

Trac:
Priority: normal to major
Points: N/A to medium

Trac:
Cc: N/A to isis

Update:

cc/crypto.c.gcov 166 800 82.82
cc/crypto_ed25519.c.gcov 12 124 91.18
cc/crypto_curve25519.c.gcov 3 85 96.59
cc/crypto_pwbox.c.gcov 1 62 98.41
cc/crypto_s2k.c.gcov 1 131 99.24
cc/aes.c.gcov 0 20 100.00
cc/crypto_format.c.gcov 0 91 100.00

Only two under-tested modules remain.

Trac:
Severity: N/A to Normal

I've got some code removal and new tests in feature16794_more.

Trac:
Status: new to needs_review

Merged that.

Trac:
Status: needs_review to assigned
Owner: N/A to nickm

Trac:
Priority: High to Medium

These seem like features, or like other stuff unlikely to be possible this month. Bumping them to 0.2.9

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.9.x-final

Trac:
Sponsor: SponsorS to SponsorS-can

Trac:
Owner: nickm to N/A

Trac:
Owner: N/A to nickm

by my latest, we're down to one under-covered file, but it's the big one:

cov/crypto.c.gcov 195 935 82.74
cov/crypto_curve25519.c.gcov 3 85 96.59
cov/crypto_ed25519.c.gcov 5 148 96.73
cov/crypto_format.c.gcov 0 92 100.00
cov/crypto_pwbox.c.gcov 1 63 98.44
cov/crypto_s2k.c.gcov 1 136 99.27
cov/aes.c.gcov 0 19 100.00

Also, looking at test_crypto, I see official-looking test vectors for:

• SHA1
• SHA256
• SHA3-{256,512}
• SHAKE256
• Curve25519
• SipHash

And I see test vectors that we generated with independent code for:

• AES
• Base16
• Base32
• Base64
• KDF-TAP
• HKDF-SHA256
• Ed25519

But not for:

• SHA512
• RSA
• DH

Trac:
Reviewer: N/A to N/A

I did some trivial exercises here this morning, in branch crypto_unit_tests. Reviewable but not finished.

Trac:
Keywords: N/A deleted, tor-tests-coverage, tor-tests-unit added

Give myself a few items for May. I hope I can do even more than this, but let's be careful.

Trac:
Keywords: N/A deleted, TorCoreTeam201605 added

Okay. In my branch (rebased as crypto_unit_tests_v2) we now have official test vectors for everything but RSA, DH, and Base*. Oh, and KDF-TAP, but KDF-TAP is ours.

On to the coverage.