Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#16795 closed enhancement (implemented)

Process-related utility code should have unit test coverage over 95%

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: testing, tor-tests-coverage, tor-tests-unit
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor: SponsorS-can

Description

x/procmon.c.gcov 45 0 0.00
x/util_process.c.gcov 5 33 86.84

Child Tickets

Change History (17)

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-final

comment:2 Changed 4 years ago by nickm

Keywords: 028-triage added

comment:3 Changed 4 years ago by nickm

Keywords: SponsorS removed
Sponsor: SponsorS

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

comment:4 Changed 4 years ago by nickm

Points: medium

comment:5 Changed 3 years ago by nickm

Severity: Normal

update:

procmon.c.gcov 13 28 68.29
util_process.c.gcov 2 38 95.00

We're getting there...

comment:6 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

Throw most 0.2.8 "NEW" tickets into 0.2.9. I expect that many of them will subsequently get triaged out.

comment:7 Changed 3 years ago by isabela

Sponsor: SponsorSSponsorS-can

comment:8 Changed 3 years ago by nickm

Keywords: tor-tests-coverage tor-tests-unit added

comment:9 Changed 3 years ago by isabela

Points: medium3

comment:10 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-final
Parent ID: #16791#17289

comment:11 Changed 3 years ago by andrea

Owner: set to andrea
Status: newassigned

comment:12 Changed 3 years ago by nickm

Milestone: Tor: unspecified
Owner: andrea deleted

comment:13 Changed 3 years ago by nickm

Status: assignednew

comment:14 Changed 3 years ago by nickm

Parent ID: #17289

Unparenting.

comment:15 Changed 2 years ago by nickm

Keywords: 028-triage removed

comment:16 Changed 2 years ago by nickm

Resolution: implemented
Status: newclosed

These modules are over 75% now, and are no longer logging seriously behind the rest of the world. Closing.

comment:17 Changed 2 years ago by nickm

*lagging

Note: See TracTickets for help on using tickets.