Opened 4 years ago

Last modified 2 years ago

#16798 new enhancement

Raise compat_* testing to over 80%

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: testing, tor-tests-coverage, tor-tests-unit
Cc: Actual Points:
Parent ID: #17288 Points: 4.5
Reviewer: Sponsor: SponsorS-can

Description

compat.c.gcov 360 426 54.20
compat_libevent.c.gcov 92 32 25.81
compat_pthreads.c.gcov 22 72 76.60
compat_threads.c.gcov 48 51 51.52

Getting 95% coverage for stuff that relies on OS functionality might not be feasible, but it would be great to get this as high as possible.

(Stubbing OS calls out is probably *not* the best answer here, even though you might think it would be. We're not only interested in whether our compatibility wrappers do the right thing when the OS behaves the way we expect: we're also interested in whether they do the right thing on the actual OS. )

Child Tickets

TicketTypeStatusOwnerSummary
#19361enhancementclosednickmImprove coverage on compat_*threads and workqueue

Change History (18)

comment:1 Changed 4 years ago by nickm

Keywords: TorCoreTeam201508 removed

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-final

comment:3 Changed 4 years ago by nickm

Keywords: 028-triage added

comment:4 Changed 4 years ago by nickm

Sponsor: SponsorS

comment:5 Changed 4 years ago by nickm

Points: medium/large

comment:6 Changed 4 years ago by nickm

Severity: Normal

Update:

compat.c.gcov 375 469 55.57
compat_libevent.c.gcov 34 86 71.67
compat_pthreads.c.gcov 19 88 82.24
compat_threads.c.gcov 75 53 41.41

That's a little improvement and a little regression.

comment:7 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

Throw most 0.2.8 "NEW" tickets into 0.2.9. I expect that many of them will subsequently get triaged out.

comment:8 Changed 3 years ago by isabela

Sponsor: SponsorSSponsorS-can

comment:9 Changed 3 years ago by nickm

Keywords: tor-tests-coverage tor-tests-unit added

comment:10 Changed 3 years ago by isabela

Points: medium/large4.5

comment:11 Changed 3 years ago by nickm

Parent ID: #16791#17288

comment:12 Changed 3 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:13 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:14 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:15 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:16 Changed 2 years ago by nickm

Keywords: 028-triage removed

comment:17 Changed 2 years ago by nickm

Keywords: isaremoved removed

comment:18 Changed 2 years ago by nickm

Latest from make check:

compat.c.gcov 276 550 66.59
compat_libevent.c.gcov 33 61 64.89
compat_pthreads.c.gcov 22 94 81.03
compat_rust.c.gcov 0 9 100.00
compat_threads.c.gcov 31 127 80.38
compat_time.c.gcov 19 100 84.03
TOTAL 381 941 71.18
Note: See TracTickets for help on using tickets.