Opened 4 years ago

Closed 3 years ago

#16800 closed defect (implemented)

Raise tortls unit test coverage as high as possible

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: testing, 028-triage
Cc: Actual Points:
Parent ID: #16791 Points: large
Reviewer: Sponsor: SponsorS

Description

Our TLS wrappers really ought to be completely covered by unit tests of one kind or another. Right now, they're among the worst-covered functions in src/common:

x/tortls.c.gcov 593 355 37.45
TOTAL 593 355 37.45

It might also be a good idea to split up these functions into backend wrappers vs functions based on those wrappers for how tor uses TLS

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-final

comment:2 Changed 4 years ago by nickm

Keywords: 028-triage added

comment:3 Changed 4 years ago by nickm

Keywords: SponsorS removed
Sponsor: SponsorS

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

comment:4 Changed 4 years ago by nickm

Points: large

comment:5 Changed 3 years ago by nickm

Resolution: implemented
Severity: Normal
Status: newclosed

This is done.

Note: See TracTickets for help on using tickets.