Opened 4 years ago

Last modified 2 years ago

#16805 new defect

Improve unit-test coverage on old and/or pure-ish functions/modules in src/or

Reported by: nickm Owned by:
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: testing, tor-tests-coverage, tor-tests-unit
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor: SponsorS-can

Description (last modified by nickm)

These files have the most old code in src/or right now, and they have a lot of functions that are mostly pure-ish functions. Let's call these low-hanging fruit.

routerparse.c.gcov 717 1620 69.32
routerlist.c.gcov 1496 588 28.21
nodelist.c.gcov 503 165 24.70
rendcache.c.gcov 332 1 0.30
networkstatus.c.gcov 681 144 17.45
policies.c.gcov 244 506 67.47
rephist.c.gcov 931 278 22.99
buffers.c.gcov 361 506 58.36

Child Tickets

Change History (17)

comment:1 Changed 4 years ago by nickm

Description: modified (diff)

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-final

comment:3 Changed 4 years ago by nickm

Keywords: 028-triage added

comment:4 Changed 4 years ago by nickm

Keywords: SponsorS removed
Sponsor: SponsorS

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

comment:5 Changed 4 years ago by nickm

Points: medium
Priority: normalmajor

comment:6 Changed 4 years ago by nickm

Severity: Normal

Update:

rephist.c.gcov 897 343 27.66
networkstatus.c.gcov 642 253 28.27
routerlist.c.gcov 1286 838 39.45
nodelist.c.gcov 385 260 40.31
buffers.c.gcov 272 510 65.22
routerparse.c.gcov 676 1668 71.16
policies.c.gcov 162 718 81.59
rendcache.c.gcov 23 358 93.96

comment:7 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

Throw most 0.2.8 "NEW" tickets into 0.2.9. I expect that many of them will subsequently get triaged out.

comment:8 Changed 3 years ago by nickm

Sponsor: SponsorSSponsorS-can

comment:9 Changed 3 years ago by nickm

Keywords: tor-tests-coverage tor-tests-unit added

comment:10 Changed 3 years ago by isabela

Points: medium3

comment:11 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-final
Parent ID: #17289

comment:12 Changed 3 years ago by andrea

Owner: set to andrea
Status: newassigned

comment:13 Changed 3 years ago by nickm

Milestone: Tor: unspecified
Owner: andrea deleted

comment:14 Changed 3 years ago by nickm

Status: assignednew

comment:15 Changed 3 years ago by nickm

Parent ID: #17289

Unparenting.

comment:16 Changed 3 years ago by chelseakomlo

I wonder if it would make sense to break this into smaller tickets (marking these as easy or for people just starting to contribute), and track them here?

comment:17 Changed 2 years ago by nickm

Keywords: 028-triage removed
Note: See TracTickets for help on using tickets.