Opened 4 years ago

Last modified 4 months ago

#16812 needs_information defect

Tor Browser leaks updater temp files on OS X

Reported by: teor Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-update
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When Tor Browser (4.5.3 or 5.0a4) performs a background update on OS X, it places MozUpdater/bgupdate/updater.app in a temporary directory.

If this file isn't deleted (I think the OS restarted, but this can also happen when Tor Browser crashes) OS X helpfully moves the files from the temporary directory to the trash on restart.

Several files in the .app directory contain the string "Tor Browser". This can leak the presence of Tor Browser even after it has been deleted, but I'm not sure how to fix it.

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by mcs

Cc: brade mcs added

Thank you for reporting this problem. In theory, we modified the Firefox updater code to avoid placing things in temporary directories, but we must have missed something. Can you provide steps to reproduce the problem? Is the temporary directory the one that $TMPDIR points to or is it another location?

The only reference to "bgupdate" that I can find in the code is in toolkit/xre/nsUpdateDriver.cpp, and in Tor Browser the code in that file has been modified to place the UpdateInfo directory under .../Tor Browser.app/TorBrowser/UpdateInfo/

comment:2 Changed 4 years ago by mcs

Status: newneeds_information

comment:3 in reply to:  1 Changed 4 years ago by teor

Replying to mcs:

Thank you for reporting this problem. In theory, we modified the Firefox updater code to avoid placing things in temporary directories, but we must have missed something. Can you provide steps to reproduce the problem?

Unfortunately, I can't reproduce it.

Is the temporary directory the one that $TMPDIR points to or is it another location?

I don't know, I only found the files after the OS moved them to the Trash after a restart. For general info on "Recovered Files" on OS X, see https://support.apple.com/kb/PH18793?locale=en_US

As a guess, the files may have been in /tmp, $TMPDIR, or under the /private/var/folders hierarchy.

The only reference to "bgupdate" that I can find in the code is in toolkit/xre/nsUpdateDriver.cpp, and in Tor Browser the code in that file has been modified to place the UpdateInfo directory under .../Tor Browser.app/TorBrowser/UpdateInfo/

I really can't say, but the only way they could have been moved to the Trash by the OS was if they were in a temporary directory (not the app directory).

comment:4 Changed 18 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:5 Changed 4 months ago by gk

Keywords: tbb-updater added

comment:6 Changed 4 months ago by gk

Keywords: tbb-update added; tbb-updater removed

Renaming keyword to make it a bit broader

Note: See TracTickets for help on using tickets.