Opened 4 years ago

Last modified 2 years ago

#16831 new enhancement

Cover dns.c with unit tests

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: testing, tor-tests-coverage, tor-tests-unit
Cc: Actual Points:
Parent ID: Points: medium
Reviewer: Sponsor:

Child Tickets

TicketTypeStatusOwnerSummary
#17495tasknewUnit-test launch_resolve() in dns.c

Change History (23)

comment:1 Changed 4 years ago by rl1987

Status: newneeds_review

comment:2 Changed 4 years ago by nickm

Description: modified (diff)
Milestone: Tor: unspecifiedTor: 0.2.7.x-final
Type: defectenhancement

comment:3 Changed 4 years ago by nickm

Keywords: TorCoreTeam201509 added

comment:4 Changed 4 years ago by nickm

Description: modified (diff)

(Whoops. modified description instead of adding comment. Reverting that.)

If this is ready I can take it. Since you call it first steps I'm guessing it's not complete yet, so won't close after merge.

comment:5 Changed 4 years ago by nickm

Keywords: TorCoreTeam201509 removed
Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final
Status: needs_reviewnew

Merged that branch, plus some cleanups. The rest can be for 0.2.8. Thanks, rl1987!

comment:6 Changed 4 years ago by nickm

Keywords: 028-triage added

comment:7 Changed 4 years ago by nickm

Sponsor: SponsorS

comment:8 Changed 4 years ago by nickm

Points: medium

comment:9 Changed 4 years ago by rl1987

Severity: Normal
Status: newneeds_review

I want to propose my dns_resolve_impl() unit-tests for merging: https://github.com/rl1987/tor/compare/ticket16831_part2_rebased

comment:10 Changed 4 years ago by nickm

from IRC, for record:

Looks good to me. Make sure it compiles with --enable-gcc-warnings and doesn't show memory leaks under valgrind, and I'll merge it.

comment:11 Changed 4 years ago by rl1987

Pushed one more commit that fixes GCC warnings. Valgrind reports no memory errors.

comment:12 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

lgtm; merged

comment:13 Changed 4 years ago by nickm

Resolution: implemented
Status: closedreopened

comment:14 Changed 4 years ago by nickm

Status: reopenednew

comment:15 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

Throw most 0.2.8 "NEW" tickets into 0.2.9. I expect that many of them will subsequently get triaged out.

comment:16 Changed 4 years ago by isabela

Sponsor: SponsorSSponsorS-can

comment:17 Changed 4 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:18 Changed 3 years ago by nickm

Keywords: SponsorS-deferred added
Sponsor: SponsorS-can

Remove the SponsorS status from these items, which we already decided to defer from 0.2.9. add the SponsorS-deferred tag instead in case we ever want to remember which ones these were.

comment:19 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:20 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:21 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:22 Changed 2 years ago by nickm

Keywords: 028-triage removed

comment:23 Changed 2 years ago by nickm

Keywords: tor-tests-coverage tor-tests-unit added; SponsorS-deferred removed
Note: See TracTickets for help on using tickets.