Media tab missing from Page Info
In Tor Browser 5.0 (and probably all ESR38-based Tor Browser releases), the Media tab is missing from Page Info. This was reported in a blog comment.
I vaguely remember that this was broken a while ago and then we fixed it (maybe in the ESR31 timeframe?)
Activity
This is a regression. The patch for #14716 (moved) (which fixed this originally for TB 4.5) needs to be updated to account for some changes that Mozilla made to the code under toolkit/components/passwordmgr/
Kathy and I are working on a patch. This bug does not occur when the security.nocertdb pref. is set to false.
Trac:
Keywords: N/A deleted, ff38-esr, tbb-5.0-regression, TorBrowserTeam201508 added-
Kathy and I posted a fixup patch: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug16842-01&id=39d233482a979b596439051b0455bb1b871512e0 Please review.
Trac:
Cc: N/A to brade
Keywords: TorBrowserTeam201508 deleted, TorBrowserTeam201508R added
Status: new to needs_review 
Okay, a couple of thoughts:
- Can't we just do something like
if (Services.prefs.getBoolPref("security.nocertdb")) { this.initializationPromise = Promise.resolve(); this._storage = null; } else { this.initializationPromise = this._storage.initialize(); }(plus the comments)? There seems no point in trying to run the whole init goop in
this._storage.initialize()if we are checking the nocertdb pref later anyway and assigning values tothis.initializationPromisedepending on it. Or maybe a better explanation: Just checking the pref (which we do anyway) to get to know whether the initialization fails due to it or not is enough; there is no need to try to run the init code, too.- You cleaned up some indentations, could you do that with the other
if (!this._storage) throw "No storage to set login saving enabled";blocks as well?
- I get
NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIPK11Token.initPassword] crypto-SDR.js:85:0at start-up and vaguely remember that the crypto initialization was broken due to
security.nocertdbas well but got fixed somehow. I can't seem to find the ticket anymore, though. Is this a different issue?-
Replying to gk:
Okay, a couple of thoughts:
- Can't we just do something like
{{{
if (Services.prefs.getBoolPref("security.nocertdb")) {
this.initializationPromise = Promise.resolve();
this._storage = null;
} else {
this.initializationPromise = this._storage.initialize();
}
}}}
(plus the comments)? There seems no point in trying to run the whole init goop in
this._storage.initialize()if we are checking the nocertdb pref later anyway and assigning values tothis.initializationPromisedepending on it. Or maybe a better explanation: Just checking the pref (which we do anyway) to get to know whether the initialization fails due to it or not is enough; there is no need to try to run the init code, too.
This is a very good idea.
- You cleaned up some indentations, could you do that with the other {{{ if (!this._storage) throw "No storage to set login saving enabled"; }}} blocks as well?
Yes, we will fix them.
- I get
{{{ NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIPK11Token.initPassword] crypto-SDR.js:85:0 }}} at start-up and vaguely remember that the crypto initialization was broken due to
security.nocertdbas well but got fixed somehow. I can't seem to find the ticket anymore, though. Is this a different issue?That is caused by this same issue... not calling _storage.initialize() should make this go away.
Thanks for your review and suggestions. We will post a new patch very soon.
- Can't we just do something like
{{{
if (Services.prefs.getBoolPref("security.nocertdb")) {
this.initializationPromise = Promise.resolve();
this._storage = null;
} else {
this.initializationPromise = this._storage.initialize();
}
}}}
(plus the comments)? There seems no point in trying to run the whole init goop in
-
Here is a revised fix that addresses gk's review comments: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug16842-02&id=dd8b29f3db500ab7586a25f2bdfa5b2af7c88607
Please review.
getFirstPartyURI failed for https://www.wickr.com/wp-content/uploads/2014/06/wickr.png: 0x80070057 On https://wickr.com/: blocked access to canvas image data from document https://wickr.com/, script from https://wickr.com/:31 getFirstPartyURI failed for http://ocsp.digicert.com/: 0x80070057 getFirstPartyURI failed for http://clients1.google.com/ocsp: 0x80070057 [NoScript HTTPS] AUTOMATIC SECURE on https://www.youtube.com: VISITOR_INFO1_LIVE=aGMzu1K7XFg; domain=.youtube.com; path=/; HttpOnly; Secure [NoScript HTTPS] AUTOMATIC SECURE on https://www.youtube.com: YSC=XgJNzqO884s; domain=.youtube.com; path=/; HttpOnly; Secure getFirstPartyURI failed for https://www.wickr.com/wp-content/uploads/2014/06/wickr.png: 0x80070057 NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIPK11Token.initPassword] crypto-SDR.js:85:0 uncaught exception: Initialization failed NS_ERROR_XPC_JS_THREW_STRING: Initialization failed'Initialization failed' when calling method: [nsILoginManagerStorage::initialize] nsLoginManager.js:156:0 NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService] security.js:333:0 NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIMIMEService.getTypeFromExtension] external-app-blocker.js line 131 > eval:1:0
