Opened 8 years ago

Closed 7 years ago

#1686 closed defect (fixed)

Incompatible with firefox 4.0b1

Reported by: dargo Owned by: mikeperry
Priority: Very High Milestone:
Component: Applications/Torbutton Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Torrbutton extension is not compatible with the latest version of firefox- 4.0b1.

Child Tickets

Change History (9)

comment:1 Changed 8 years ago by tasturex

A specific incompatibility with Firefox 4.0b1:

Torbutton 1.2.5; Windows XP Pro.

Back button (and hence also Forward button) does not work with Tor Button add-in enabled. Firefox 'Back' context/menu item also disabled.

Repro:

  1. Start a new Firefox session with Tor Button disabled.
  2. Open page: www.google.co.uk
  3. Click Google menu items: Images, News, Gmail to go to their respective pages in turn.
  4. Note that Firefox back button is enabled and works.
  5. Start a new Firefox session with Tor Button enabled.
  6. Open page: www.google.co.uk
  7. Repeat step 3.

Result:

Firefox back button is disabled so you can't go back from Gmail to News, Images and Search.

comment:2 Changed 8 years ago by mikeperry

Priority: normalcritical

comment:3 Changed 8 years ago by mikeperry

Resolution: fixed
Status: newclosed

Should be fixed in 1.3.1-alpha. Reopen if not.

comment:4 Changed 7 years ago by spearmint

Resolution: fixed
Status: closedreopened

It doesn't work properly, instead you are constantly bombarded with [JavaScript Application] modal dialog boxes (this is in Linux) containing the text:

Torbutton Exception in sandbox evaluation. Date hooks not applied:
TypeError: can't convert undefined to object

comment:5 in reply to:  4 Changed 7 years ago by spearmint

Replying to spearmint:

It doesn't work properly, instead you are constantly bombarded with [JavaScript Application] modal dialog boxes (this is in Linux) containing the text:

Torbutton Exception in sandbox evaluation. Date hooks not applied:
TypeError: can't convert undefined to object

Apologies, should note this is with firefox 4.0 beta 12 not 1, still that's even worse.

comment:6 Changed 7 years ago by spearmint

Priority: criticalblocker

comment:7 Changed 7 years ago by mbite

Summary: Incompatible with firefox 4.0b1Incompatible with firefox 4.0 RC

I can confirm this with Firefox nightly 4.0b13pre (2011-03-17). So as far as i can conclude, this bug applies to Firefox 4 RC as well.

I should add that these dialog boxes appearing only if checkbox "Security Settings -> Dynamic Content -> Hook dangerous javascript (crucial)" enabled.

comment:8 Changed 7 years ago by mbite

Just checked torbutton from git (c3e5474) with Firefox 4 RC. It works fine without any dialog boxes.

So my (random uneducated) guess is that these dialog boxes were about #2465 and we should wait for Torbutton 1.3.2

Thanks for your hard work, @mikeperry!

comment:9 Changed 7 years ago by rransom

Priority: blockercritical
Resolution: fixed
Status: reopenedclosed
Summary: Incompatible with firefox 4.0 RCIncompatible with firefox 4.0b1

See #2421 and #2633, and please stop fiddling with this ticket.

Note: See TracTickets for help on using tickets.