Opened 4 years ago

Closed 4 years ago

#16860 closed defect (fixed)

Gnome3: avoid duplicate icon when in favorite

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability, TorBrowserTeam201508R, MikePerry201508R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When the Tor Browser (version 5.0) is registered (using the --register argument) it is possible to pin the icon into your favorites in Gnome3 (left bar when pressing the windows key)
But when you run the Tor browser you get two icons: one for the favorite and a new icon for the running instance.
Normally applications reuse the favorite icon so that there is always only one icon for a running application.

The fix for this is simple. The following line needs to be added to ~/.local/share/applications/start-tor-browser.desktop:

StartupWMClass=Tor Browser 

Can this be added to the default desktop file? It may impact Ubuntu users using Unity too, but I don't have an Ubuntu box to try this on. And I'm not sure about any other environments that uses a similar system.

Child Tickets

Change History (3)

comment:1 Changed 4 years ago by gk

Keywords: tbb-usability TorBrowserTeam201508R MikePerry201508R added
Status: newneeds_review

comment:2 Changed 4 years ago by mcs

r=mcs
This is also an improvement for Unity users (for example, with this fix I get a seperate Tor Browser icon in my dock instead of a Firefox icon).

comment:3 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks for review and testing. No need to bother Mike then, I guess. Applied as commit ee2e10d6e038b2b057499034437b4b6a393a4906 (master) and commit a3473c7b35e83db97df1b39175c1ca4c717e9364 (maint-5.0).

Note: See TracTickets for help on using tickets.