Opened 4 years ago

Last modified 23 months ago

#16886 reopened defect

"Add-on compatibility check dialog" contains Firefox logo

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-branding
Cc: brade, mcs, Dbryrtfbcbhgf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There is another place where we have to replace the Firefox logo with the Tor Browser one: the "Add-on compatibility check dialog".

Child Tickets

Change History (8)

comment:1 Changed 4 years ago by mcs

Cc: brade mcs added

comment:2 Changed 4 years ago by gk

Severity: Normal

Resolved #18199 as duplicate.

comment:3 Changed 4 years ago by mcs

It looks like Mozilla is removing this, although I have not looked at the following bug report in detail: https://bugzilla.mozilla.org/show_bug.cgi?id=1262880

comment:4 Changed 3 years ago by gk

Keywords: ff52-esr-will-have added

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: newclosed

This will be fixed in 7.0a3 which is based on Firefox 52 ESR.

comment:6 Changed 2 years ago by gk

Cc: Dbryrtfbcbhgf added
Keywords: ff52-esr-will-have removed
Resolution: fixed
Status: closedreopened

We were to fast it seems. For some reason this is still happening in ESR52-based Tor Browsers (see: #23208). Resolving #23208 as duplicate and reopening this bug.

comment:7 Changed 2 years ago by cypherpunks

Mozilla removed "Add-on compatibility check", but not the dialog (facepalm).

comment:8 Changed 23 months ago by mcs

In Firefox <= 57, there is still a branded dialog that is shown after the post-update restart (which is why we still see it in Tor Browser after each update). But in Firefox 57 and newer that old XUL-based dialog has been replaced with a simpler HTML-based window, as shown here:
https://bug1353194.bmoattachments.org/attachment.cgi?id=8905214

Here is the bug where the work was done:
https://bugzilla.mozilla.org/show_bug.cgi?id=1353194

We should take another look at this in the ESR 60 timeframe to see if there are any branding issues with the new window (text or images).

In the meantime, we can fix this problem by putting a Tor Browser icon in browser/branding/official/content/icon48.png (see ticket:10888#comment:8).

Note: See TracTickets for help on using tickets.