Opened 4 years ago

Closed 4 years ago

#16887 closed defect (fixed)

intl.accept_languages value

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-torbutton, tbb-5.0-regression, TorBrowserTeam201509R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For TBB based on ESR38, the Accept-Language header value has been changed (previously "en-us, en" now "en-US, en") and in src/chrome/content/torbutton.js, intl.accept_language still has the former value.
Also see bug #13277

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by gk

Component: TorbuttonTor Browser
Keywords: tbb-torbutton tbb-5.0-regression TorBrowserTeam201508R added
Status: newneeds_review

comment:2 Changed 4 years ago by gk

Owner: set to tbb-team
Status: needs_reviewassigned

comment:3 Changed 4 years ago by gk

Status: assignedneeds_review

comment:4 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201509R added; TorBrowserTeam201508R removed

Transfer review tickets to Sept.

comment:5 Changed 4 years ago by arthuredelstein

The patch looks good to me.

comment:6 Changed 4 years ago by cypherpunks

But upon careful inspection, this brings up the issue of TorBrowser ignoring the intl.accept_languages setting altogether, which is a bit more problematic.

comment:7 in reply to:  6 Changed 4 years ago by yawning

Replying to cypherpunks:

But upon careful inspection, this brings up the issue of TorBrowser ignoring the intl.accept_languages setting altogether, which is a bit more problematic.

Isn't honoring it worse for user anonymity? One could make an argument that "People who change the value get what they deserve in terms of anonymity set reduction", and some people may be ok with that but I doubt everyone that changes it will understand the impact of doing so.

Eg: My anonymity set isn't going to be very big if I change the value to "tlh-US, tlh" (Klingon)

comment:8 in reply to:  6 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to cypherpunks:

But upon careful inspection, this brings up the issue of TorBrowser ignoring the intl.accept_languages setting altogether, which is a bit more problematic.

It does not do this. The short story is: it only does not like lower case country codes like "us" in "en-us" anymore. The longer story is contained in https://bugzilla.mozilla.org/show_bug.cgi?id=889335 and https://html5.org/r/8458.

Fixed in commit c39a9540dc693d8f5b14636c643530f29e1c0ead.

Note: See TracTickets for help on using tickets.