Opened 9 years ago

Closed 6 years ago

#1689 closed defect (fixed)

tordnsel 0.0.6 does not compile on GHC6.8.

Reported by: nejucomo Owned by:
Priority: Medium Milestone:
Component: Core Tor/TorDNSEL Version:
Severity: Keywords: tordnsel ghc haskell
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

GHC changed various compiler flag requirements as well as APIs between ghc6.6 and ghc6.8.

This patch allows tordnsel to compile against ghc6.8 (which is on lenny).

This patch deserves security review. I'm not certain what implications the compiler flags have.

The most dubious change is using "unsafePerformIO . Data.ByteString.Unsafe.unsafePackAddress" which could conceivably introduce memory management issues. I have a feeling this is not likely as long as unsafePackAddress is idempotent (in which case the order of side effects hopefully does not matter).

Child Tickets

Attachments (1)

tordnsel-0.0.6_compile_on_ghc6.8.patch (11.2 KB) - added by nejucomo 9 years ago.
Patch against tordnsel 0.0.6 as fetched from the mirror link.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by nejucomo

Patch against tordnsel 0.0.6 as fetched from the mirror link.

comment:1 Changed 9 years ago by nickm

Component: GetTor- Select a component

comment:2 Changed 8 years ago by karsten

Component: - Select a componentTorDNSEL/TorBEL

comment:3 Changed 6 years ago by arlolra

Resolution: fixed
Status: newclosed

On sergii,

ghc --version
The Glorious Glasgow Haskell Compilation System, version 6.12.1

so presumably this was fixed.

Note: See TracTickets for help on using tickets.