Circuit display should show original circuit for each tab

Instead of storing circuits per credentials, let's store them per-tab and then display the original circuit for each tab, even if that circuit has since closed and been replaced under the same credentials.

added component::applications/tor browser gitlab-tb-torbutton owner::tbb-team priority::medium severity::normal status::new tbb-circuit-display tbb-torbutton type::defect labels

Trac:
Keywords: N/A deleted, TorBrowserTeam201509 added

Trac:
Cc: mikeperry to mikeperry, gk

Trac:
Sponsor: N/A to N/A
Owner: N/A to tbb-team
Keywords: N/A deleted, tbb-torbutton, tbb-circuit-display added
Component: Torbutton to Tor Browser

Trac:
Keywords: TorBrowserTeam201509 deleted, TorBrowserTeam201510 added

Trac:
Keywords: TorBrowserTeam201510 deleted, N/A added

It looks like a nonsense. Why do we need the original circuit instead of the current one for the first party?

Trac:
Status: new to needs_information
Reviewer: N/A to N/A
Severity: N/A to Normal

Replying to cypherpunks:

It looks like a nonsense. Why do we need the original circuit instead of the current one for the first party?

I think that's because we want to make sure to show the circuit that actually loaded the content in a tab regardless what the current circuit is/were if one was about to fetch the content again. However, I am not sure if those corner cases are actually possible but I assume so.

Trac:
Status: needs_information to new

Add magic gitlab keyword.

Trac:
Keywords: N/A deleted, gitlab-tb-torbutton added

mentioned in issue #30115 (moved)

moved to tpo/applications/torbutton#16936 (closed)