Opened 4 years ago

Closed 4 years ago

#16955 closed defect (invalid)

"make alpha" fails to find the right version or something.

Reported by: yawning Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: gitian, sucks
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm trying to test a tor-browser-bundle feature branch based off master, and make alpha fails. make nightly got past this point and blew up in my face due to #16909, so I'm 2 attempted builds for a simple feature branch down.

When I asked mike about this he seemed to think it was a version extraction failure or something.

Child Tickets

Attachments (1)

build.log.gz (37.5 KB) - added by yawning 4 years ago.

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by yawning

Attachment: build.log.gz added

comment:1 Changed 4 years ago by yawning

Cc: boklm added

comment:2 Changed 4 years ago by boklm

Can you run and give the output of "./get-tb-version alpha" in the gitian directory ?

When I run it in your branch, I get this:

$ ./get-tb-version alpha
TORBROWSER_VERSION=5.5a2
TORBROWSER_BUILDDIR=5.5a2-005158dcefdd
TORBROWSER_SYMLINK_VERSION=0

Does your clone of the repository have tags from the main repository ?

comment:3 Changed 4 years ago by yawning

$ ./get-tb-version alpha
Could not find TORBROWSER version from tags

IIRC I just naively cloned my fork of the the repo, so I don't have any tags, which probably(?) explains the failure. If I missed documentation for this or something, my apologies.

Last edited 4 years ago by yawning (previous) (diff)

comment:4 Changed 4 years ago by yawning

Ah ha, yeah. My working tor-browser-bundle repo that sits on github is lacking tags of any kind since it's just a fork of master with some feature branches (it predates all this automagic stuff). I assume if I clone the git.tp.o repo, add my repo as a remote and try to use my branch things will work, but I have a kludgetacular nightly build going right now so it'll be multiple hours till I can test it.

comment:5 Changed 4 years ago by boklm

Ah yes, if you only cloned your github repo then you don't have the tags. You can add the git.tpo repo as remote and "git fetch" it to add them.

We should probably exit with a more explicit error explaining the problem when no tags are found.

comment:6 Changed 4 years ago by yawning

Yeah, I'd be ok with NABing or wontfixing this, as long as a separate ticket is opened to catch this situation early in the build process (since it's a build env setup failure), rather than several hours in (Or just use this ticket for that).

Thanks for the assistance!

comment:7 Changed 4 years ago by boklm

Resolution: invalid
Status: newclosed

Ok, I opened ticket #16956 for that.

Note: See TracTickets for help on using tickets.