Opened 5 years ago

Closed 5 years ago

#16956 closed enhancement (fixed)

Make the error more explicit when tor browser version cannot be extracted from git tags

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201509R, tbb-gitian
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


To avoid problems like #16955 we should exit early with a message explaining the problem when no version can be extracted from the tags, rather than starting a build which fails with a confusing error message.

Child Tickets

Attachments (1)

0001-Bug-16956-Make-explicit-error-when-no-version-tag-is.patch (765 bytes) - added by boklm 5 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 5 years ago by boklm

Keywords: TorBrowserTeam201509R tbb-gitian added; TorBrowserTeam201509 removed
Status: newneeds_review

I attached a patch to fix that.

comment:2 Changed 5 years ago by boklm

With this patch, we now have an error like this when no version tag is found (I added a build-beta rule to test this, as we currently don't have beta tags):

$ make build-beta
./ versions.beta
Could not find TORBROWSER version from tags. Does your git repo have tags ?
Makefile:32: recipe for target 'build-beta' failed
make: *** [build-beta] Error 1

comment:3 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. I fixed the whitespace typo and committed the patch as 4a83432493057ad9cb60416b1fc121b51cbff238 on master and 5a8177f0164a3f19fe11a970b4b61dea04c334a2 on maint-5.0.

Note: See TracTickets for help on using tickets.