Opened 5 years ago

Closed 5 years ago

#16961 closed defect (fixed)

Switch from displaying "family" field to new "alleged_family" and "effective_family" fields

Reported by: karsten Owned by: phw
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Onionoo recently introduced two new fields "alleged_family" and "effective_family" that together contain all entries of the now deprecated "family" field. We should stop displaying "family" and instead display the union of "alleged_family" and "effective_family".

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by karsten

Status: newneeds_review

Please find branch task-16961 in my public repository for a possible fix. Please review and test carefully before merging. Thanks!

comment:2 Changed 5 years ago by clv

Severity: Normal

Please see this commit. I updated the patch to show both effective and alleged family fields but highlighting the existence of alleged ones (see a screenshot here).

comment:3 Changed 5 years ago by karsten

Looks good to me! phw, please review, tweak if necessary, and either merge or tell me to merge. (I'd like to take out the "family" field from Onionoo really soon.) Thanks!

comment:4 in reply to:  2 Changed 5 years ago by phw

Resolution: fixed
Status: needs_reviewclosed

Replying to clv:

Please see this commit. I updated the patch to show both effective and alleged family fields but highlighting the existence of alleged ones (see a screenshot here).

Looks good to me too, thanks a lot, clv. Merged and deployed.

Note: See TracTickets for help on using tickets.