Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16962 closed defect (fixed)

Switch from displaying "family" field to new "alleged_family" and "effective_family" fields

Reported by: karsten Owned by: isis
Priority: Medium Milestone:
Component: Metrics/Globe Version:
Severity: Normal Keywords: globe-0.4.10
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Onionoo recently introduced two new fields "alleged_family" and "effective_family" that together contain all entries of the now deprecated "family" field. We should stop displaying "family" and instead display the union of "alleged_family" and "effective_family".

Child Tickets

Attachments (1)

switch-family-to-effective-alleged-family.diff (6.0 KB) - added by clv 4 years ago.
patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by karsten

See #16961 for the discussion of the Atlas fix. Maybe that's helpful here.

comment:2 Changed 4 years ago by clv

Please review branch task-1696 on my personal repo. I made a fix for fetching both new fields and formatting the output with both fields under the same "Family" section but alleged_family entries are presented with a special CSS class to notice the difference (screenshot available here - at the end of page).

I wasn't sure if its OK to drop the family field yet (on default.js:61).

comment:3 Changed 4 years ago by isis

Status: newneeds_review

comment:4 in reply to:  2 Changed 4 years ago by isis

Status: needs_reviewneeds_revision

Replying to clv:

Please review branch task-1696 on my personal repo. I made a fix for fetching both new fields and formatting the output with both fields under the same "Family" section but alleged_family entries are presented with a special CSS class to notice the difference (screenshot available here - at the end of page).

I wasn't sure if its OK to drop the family field yet (on default.js:61).


Hey, clv! Thanks for the patch! I've reviewed it, and it looks great to me. Would you be able to add another commit to remove the old "family" field? (I think it's probably okay to remove it.)


Changed 4 years ago by clv

patch

comment:5 Changed 4 years ago by clv

Done!

comment:6 Changed 4 years ago by clv

Severity: Normal
Status: needs_revisionneeds_review

Added a commit with new changes. This time I also changed unit testing test to consider effective and alleged family instead of family field. Previous commit  removed family field from JS model.

comment:7 Changed 4 years ago by karsten

I tried out the patch locally, and it looks good to me! isis, can you please take another look and merge if you like it? (I'd like to take out the "family" field from Onionoo really soon.) Thanks!

comment:8 Changed 4 years ago by isis

Keywords: globe-0.4.10 added
Resolution: fixed
Status: needs_reviewclosed

Alright, this is merged! Sorry for the delay. And thanks again, clv!

comment:9 Changed 4 years ago by karsten

Note: See TracTickets for help on using tickets.