Opened 4 years ago

Closed 4 years ago

#16963 closed defect (fixed)

When we are not on a tag, TORBROWSER_BUILDDIR includes the wrong commit hash

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201509R, tbb-gitian
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When we are not on a tag, TORBROWSER_BUILDDIR is set to the version from the latest tag and a commit hash. The commit hash should be the current commit, but instead the commit of the latest tag is used.

Child Tickets

Attachments (1)

0001-Bug-16963-use-the-right-commit-hash-in-TORBROWSER_BU.patch (853 bytes) - added by boklm 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 4 years ago by boklm

Keywords: TorBrowserTeam201509R tbb-gitian added; TorBrowserTeam201509 removed
Status: newneeds_review

I attached a patch to fix this.

Without the patch:

$ git show -s --oneline 
fb4e9c0b57e7 Point detailsURL to our blog
$ ./get-tb-version alpha
TORBROWSER_VERSION=5.5a2
TORBROWSER_BUILDDIR=5.5a2-005158dcefdd
TORBROWSER_SYMLINK_VERSION=0

With the patch:

$ git show -s --oneline 
b4465b0552ba Bug 16963: use the right commit hash in TORBROWSER_BUILDDIR
$ ./get-tb-version alpha
TORBROWSER_VERSION=5.5a2
TORBROWSER_BUILDDIR=5.5a2-b4465b0552ba
TORBROWSER_SYMLINK_VERSION=0

comment:2 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Applied as commit e594dfac1fdb2bf32a51a0020e59fa1a9826f6ba on master and as commit bc17a40f050335b9dbfaff73ac0233e48ead546e on maint-5.0

Note: See TracTickets for help on using tickets.