Opened 5 years ago

Closed 5 years ago

#16973 closed defect (fixed)

Downloading incremental MAR files is broken

Reported by: gk Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201509R, tbb-gitian
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


As Yawning noticed in #10140:

gpg: keyblock resource `../../gitian/gpg/torbrowser.gpg': file open error
gpg: Signature made Tue Aug 11 15:14:23 2015 GMT using RSA key ID D40814E0
gpg: Can't check signature: public key not found
Error: Error checking gpg signature for version 5.5a1
make: *** [incrementals-alpha] Error 1

It seems gpg_keyring is one level too deep as ../gitian/torbrowser.gpg fixes the issue for me. But there is more:

signmar: error while loading shared libraries: cannot open shared object file: No such file or directory
Error: Error unsigning tor-browser-linux32-5.5a1_ar.mar
make: *** [incrementals-alpha] Error 1

LD_LIBRARY_PATH should help here.

Child Tickets

Attachments (2)

0001-Bug-16973-fix-gpg-keyring-path.patch (1.1 KB) - added by boklm 5 years ago.
0002-Bug-16973-Add-the-mar-tools-dir-to-LD_LIBRARY_PATH.patch (921 bytes) - added by boklm 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by boklm

comment:1 Changed 5 years ago by boklm

Keywords: TorBrowserTeam201509R added; TorBrowserTeam201509 removed
Status: newneeds_review

I attached 2 patches to fix this.

comment:2 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good and works for me. These are now commit 199808ddbe8e9f640bc8cef57e6f09f2f3070d95 and 7097c9651a556a314a8265226e2e2c111934a7b0 on master and commit badf55cb0fdda5c3c893f01f996a29a4e105d3d7 and f3a1676797a35a63ff2e40f89e6aab169b8661b0 on maint-5.0.

Note: See TracTickets for help on using tickets.