Opened 4 years ago

Closed 3 years ago

#17003 closed enhancement (implemented)

Improve test coverage on src/or/directory.c

Reported by: rjunior Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: testing, TorCoreTeam201509, 028-triaged, pre028-patch
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor: SponsorS

Description

Related branch on github (https://github.com/twstrike/tor/tree/directory-tests)

I believe it's related to #16805

Child Tickets

Attachments (2)

0001-Add-tests-for-src-or-directory.c.patch (19.0 KB) - added by rjunior 4 years ago.
patch generated with git format-patch
leaks_dir (88.0 KB) - added by nickm 4 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 4 years ago by rjunior

Status: newneeds_review

Changed 4 years ago by rjunior

patch generated with git format-patch

comment:2 Changed 4 years ago by nickm

Keywords: testing TorCoreTeam201509 added
Milestone: Tor: 0.2.8.x-final

comment:3 Changed 4 years ago by nickm

This looks good to me at first glance; we should take another look before merging.

comment:4 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:5 Changed 4 years ago by nickm

Sponsor: SponsorS

comment:6 Changed 4 years ago by nickm

Points: small

Changed 4 years ago by nickm

Attachment: leaks_dir added

comment:7 Changed 4 years ago by nickm

Severity: Normal
Status: needs_reviewneeds_revision

We try to have our tests run without memory leaks. I've attacked a valgrind log.

comment:8 Changed 4 years ago by nickm

Keywords: pre028-patch added

comment:9 Changed 3 years ago by olabini

@nickm - do you have the suppression file you're using for valgrind somewhere?

comment:10 Changed 3 years ago by nickm

I usually go with the instructions in doc/HACKING/HelpfulTools.md

comment:11 Changed 3 years ago by olabini

OK, I've fixed all the memory leaks that were in the valgrind log.
I also made it so it compiles with gcc-warnings on.

comment:12 Changed 3 years ago by olabini

Status: needs_revisionneeds_review

comment:13 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

merged!

Note: See TracTickets for help on using tickets.