Opened 4 years ago

Last modified 3 months ago

#17028 needs_revision defect

silently ignore a bad/missing --defaults-torrc

Reported by: lunar Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy tor-client bootstrap
Cc: mcs Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor:

Description

The nightly Debian packages for wheezy were broken because they were missing /usr/share/tor/tor-service-defaults-torrc. The issue was not easy to diagnose because Tor currently silently ignore a --defaults-torrc pointing to a non-existing file.

At least a warning would be good, but I think it would be even better to bail out unless --ignore-missing-torrc is specified.

Child Tickets

Change History (23)

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-final

Hm. Are we talking about the case where a --defaults-torrc is explicitly specified and doesn't exist, or where the default defaults-torrc file doesn't exist?

Making the first one an error wouldn't be too hard.

Does this need to be in 0.2.7?

comment:2 in reply to:  1 Changed 4 years ago by lunar

Replying to nickm:

Hm. Are we talking about the case where a --defaults-torrc is explicitly specified and doesn't exist, or where the default defaults-torrc file doesn't exist?

I had the first in mind.

Does this need to be in 0.2.7?

I would follow weasel's opinion on this.

comment:3 Changed 4 years ago by nickm

Status: newneeds_review

On IRC, weasel says we can target this for 0.2.8.

ticket17028 is a totally untested fix for this I wrote; I should write a changes file for it and test it myself a little before I ask anybody else to try it.

comment:4 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:5 Changed 4 years ago by nickm

Points: medium

The coding here is "small", but the decision-making is "medium"

comment:6 Changed 4 years ago by nickm

Status: needs_reviewneeds_revision

Hm. actually the test shows that it crashes immediately. Better try harder.

comment:7 Changed 4 years ago by mcs

Cc: mcs added

comment:8 Changed 4 years ago by nickm

Keywords: pre028-patch added

comment:9 Changed 4 years ago by nickm

Severity: Normal

atagar says the place in stem to add tests for this is https://gitweb.torproject.org/stem.git/tree/test/integ/process.py

comment:10 Changed 4 years ago by nickm

Owner: set to nickm
Status: needs_revisionassigned

Setting nickm as the owner of this needs_revision ticket.

comment:11 Changed 4 years ago by nickm

Status: assignedneeds_revision

comment:12 Changed 4 years ago by nickm

Keywords: intro added

comment:13 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

Maybe in the next release

comment:14 Changed 3 years ago by isabela

Points: medium3

comment:15 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

Sorry; I don't think I'll have cycles to do this in 0.2.9. Somebody else please pull this back in if you decide to fix up my branch.

comment:16 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:17 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:18 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:19 Changed 2 years ago by nickm

Keywords: 028-triaged removed

comment:20 Changed 2 years ago by nickm

Keywords: pre028-patch removed

comment:21 Changed 2 years ago by nickm

Keywords: easy tor-client bootstrap added; intro removed
Summary: silently ignore a bad --defaults-torrcsilently ignore a bad/missing --defaults-torrc

comment:22 Changed 3 months ago by nickm

Owner: nickm deleted
Status: needs_revisionassigned

comment:23 Changed 3 months ago by nickm

Status: assignedneeds_revision

None of these revisions are in my near-term plans.

Note: See TracTickets for help on using tickets.