Opened 3 years ago

Closed 3 years ago

#17060 closed defect (fixed)

routerset_parse doesn't accept IPv6 addresses

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.1.10-alpha
Severity: Keywords: TorCoreTeam201509, 028-triaged
Cc: Actual Points:
Parent ID: #5788 Points: small/medium
Reviewer: Sponsor:

Description

routerset_parse accepts addresses containing '.' (literal IPv4) and '*' (wildcard, potentially IPv4 and/or IPv6). But it doesn't accept addresses containing ':' (literal IPv6).

This is a bugfix on 3ce6e2fba290 (Thu Jul 24 13:44:04 2008) in 0.2.1.3-alpha, and similar code which added IPv6 address parsing capabilities to tor_addr_parse_mask_ports.

Child Tickets

Change History (10)

comment:1 Changed 3 years ago by teor

Keywords: Post027Freeze TorCoreTeam201509 added
Status: newneeds_review
Version: Tor: 0.2.1.10-alpha

See my branch routerset-parse-IPv6-literals on https://github.com/teor2345/tor.git

While IPv6 support was added to tor_addr_parse_mask_ports in 0.2.1.3-alpha, IPv6 address literals were not allowed by routerset_parse until now.

comment:2 Changed 3 years ago by teor

Added unit tests for parsing address wildcards, IPv4 literals, and IPv6 literals.

comment:3 Changed 3 years ago by gk

Component: - Select a componentTor

comment:4 Changed 3 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

Any strong reason this needs to be in 0.2.7? If so, please move it back. Otherwise, it strongly seems like a wait-for-0.2.8 thing.

comment:5 Changed 3 years ago by teor

Keywords: Post027Freeze removed

Only if there's demand for it (I haven't seen any complaints).

comment:6 Changed 3 years ago by teor

Parent ID: #5788

The lack of this feature makes configuring IPv6-only clients/relays harder.

comment:7 Changed 3 years ago by rl1987

The above patch looks good to me.

comment:8 Changed 3 years ago by nickm

Keywords: 028-triaged added

comment:9 Changed 3 years ago by nickm

Points: small/medium

comment:10 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged, with minor conflicts!

Note: See TracTickets for help on using tickets.