Opened 5 years ago

Last modified 3 years ago

#17066 new task

Avoid assuming relays have a single IPv4/IPv6 address

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords: tor-relay multihome
Cc: Actual Points:
Parent ID: #5788 Points: 3
Reviewer: Sponsor:

Description

Many areas of the Tor codebase assume that a relay has a single IPv4 address, or perhaps an IPv4 and an IPv6 address. Multi-homed relays may have many such addresses.

Therefore, some callers of get_interface_address[6] may be able to use the list of addresses from the get_interface_address6_list function introduced in #17027.

We should review all calls to get_interface_address and get_interface_address6 to see if they would benefit from using a list instead.

Child Tickets

Change History (19)

comment:1 Changed 5 years ago by teor

Parent ID: → #5788

Related to #5788

comment:2 Changed 5 years ago by nickm

Keywords: 028-triage added

comment:3 Changed 5 years ago by nickm

Points: → medium

comment:4 Changed 5 years ago by isabela

Keywords: TorCoreTeam201511 added

comment:5 Changed 5 years ago by isabela

Keywords: TorCoreTeam201510 removed

comment:6 Changed 5 years ago by teor

Keywords: TorCoreTeam201512 added; TorCoreTeam201511 removed
Severity: → Normal
Type: enhancement → task

I don't think I'm going to have time for IPv6 and addresses until December.
This is a code review task, many people can help log tickets and patches.

comment:7 Changed 5 years ago by nickm

Owner: set to teor
Status: new → assigned

Tentatively assigning one to you, teor, unless you find somebody else who's excited. :)

comment:8 Changed 5 years ago by nickm

Keywords: TorCoreTeam201601 201512-deferred added; TorCoreTeam201512 removed

Perhaps in January?

comment:9 Changed 5 years ago by teor

Milestone: Tor: 0.2.8.x-final → Tor: 0.2.9.x-final

I think this can wait for 0.2.9, #17840 catches a lot of these anyway, and #6939 will catch another important instance.

comment:10 Changed 5 years ago by teor

Keywords: TorCoreTeam201601 removed

comment:11 Changed 4 years ago by isabela

Points: medium → 3

comment:12 Changed 4 years ago by teor

Owner: teor deleted

I don't have time to do this in 0.2.9.

comment:13 Changed 4 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-final → Tor: 0.2.???

comment:14 Changed 4 years ago by teor

Milestone: Tor: 0.2.??? → Tor: 0.3.???

Milestone renamed

comment:15 Changed 4 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.??? → Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:16 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:17 Changed 3 years ago by nickm

Keywords: 028-triage 201512-deferred isaremoved removed

comment:18 Changed 3 years ago by nickm

Status: assigned → new

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:19 Changed 3 years ago by nickm

Keywords: tor-relay multihome added
Note: See TracTickets for help on using tickets.