Opened 4 years ago

Closed 4 years ago

#17084 closed enhancement (implemented)

Improve coverage on src/common/util_format.c

Reported by: rjunior Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: testing, 028-triaged
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor: SponsorS

Description

The changes are in the branch "util_format_tests"

​​​​​​https://github.com/twstrike/tor_for_patching/tree/util_format_tests

Child Tickets

Change History (11)

comment:1 Changed 4 years ago by rjunior

Status: newneeds_review

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-final

comment:3 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:4 Changed 4 years ago by nickm

Sponsor: SponsorS

comment:5 Changed 4 years ago by nickm

Points: small

mark these testing tickets in needs_review as 'small work remaining'

comment:6 Changed 4 years ago by nickm

Hmm. These improve coverage, and some of them test real success cases. I've made some comments on github. Now I'll merge these, and add notes where more tests are needed.

comment:7 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged, tidied, more tests added.

comment:8 Changed 4 years ago by olabini

I have pushed some new commits to this branch that adds success tests for all the comments, and fixes spaces as well.

comment:9 Changed 4 years ago by nickm

Resolution: implemented
Status: closedreopened

comment:10 Changed 4 years ago by nickm

Status: reopenedneeds_review

comment:11 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged that, integrating both sets of tests. Thank you!

Note: See TracTickets for help on using tickets.