Adapt nightly (and alpha) Tor Browsers to #15482 being fixed

With tor master and with the next tor alpha we don't need to ship our patch for #15482 (moved) anymore. The descriptors and the torrc-defaults file need to get adapted accordingly (the latter needs KeepAliveIsolateSOCKSAuth set).

added TorBrowserTeam201510R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed status::closed type::defect labels

Trac:
Summary: Adapt nightly (and alpha) Tor Browses to #15482 (moved) being fixed to Adapt nightly (and alpha) Tor Browsers to #15482 (moved) being fixed

Trac:
Cc: N/A to yawning

bug_17124 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_17124&id=264de71bbd0bbc9c691664c01f1a746733e03760) has the fix. Given that KeepAliveIsolateSOCKSAuth is basically on by default just removing the patch application should be enough.

Trac:
Sponsor: N/A to N/A
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201510R added

Err, the option isn't on by default, even though I wanted to make it so. :(

Interesting. But your changes file in 54510d4d1a66d2dd9a618699bd2e51bf4ade4dea says so. Is that changes entry wrong then?

It seems I failed at parsing the changes file correctly. bug_17124_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_17124_v2&id=fb426978fe732a91bf9828c1b24daad5b11fcb5a) has the added KeepAliveIsolateSOCKSAuth 1 in the torrc-defaults files.

NACK, it's a per-SocksPort tunable, and not something that's set on it's own.

Something like:

SocksPort 9150 IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth

Sorry for me being dumb here. :( bug_17124_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_17124_v3&id=fed9df74f3fc35a898710b8186efbfd250ea926d) should have that fixed now.

Should be fixed now in commit fed9df74f3fc35a898710b8186efbfd250ea926d.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#17124 (closed)