Opened 4 years ago

Closed 4 years ago

#17124 closed defect (fixed)

Adapt nightly (and alpha) Tor Browsers to #15482 being fixed

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201510R
Cc: yawning Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

With tor master and with the next tor alpha we don't need to ship our patch for #15482 anymore. The descriptors and the torrc-defaults file need to get adapted accordingly (the latter needs KeepAliveIsolateSOCKSAuth set).

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by gk

Summary: Adapt nightly (and alpha) Tor Browses to #15482 being fixedAdapt nightly (and alpha) Tor Browsers to #15482 being fixed

comment:2 Changed 4 years ago by yawning

Cc: yawning added

comment:3 Changed 4 years ago by gk

Keywords: TorBrowserTeam201510R added
Status: newneeds_review

bug_17124 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_17124&id=264de71bbd0bbc9c691664c01f1a746733e03760) has the fix. Given that KeepAliveIsolateSOCKSAuth is basically on by default just removing the patch application should be enough.

comment:4 Changed 4 years ago by yawning

Err, the option isn't on by default, even though I wanted to make it so. :(

comment:5 Changed 4 years ago by gk

Interesting. But your changes file in 54510d4d1a66d2dd9a618699bd2e51bf4ade4dea says so. Is that changes entry wrong then?

comment:6 Changed 4 years ago by gk

It seems I failed at parsing the changes file correctly. bug_17124_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_17124_v2&id=fb426978fe732a91bf9828c1b24daad5b11fcb5a) has the added KeepAliveIsolateSOCKSAuth 1 in the torrc-defaults files.

comment:7 Changed 4 years ago by yawning

NACK, it's a per-SocksPort tunable, and not something that's set on it's own.

Something like:

SocksPort 9150 IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth

comment:9 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Should be fixed now in commit fed9df74f3fc35a898710b8186efbfd250ea926d.

Note: See TracTickets for help on using tickets.