Opened 4 years ago

Last modified 6 months ago

#17140 new defect

When Tor Browser updater runs, prefs don't get updated

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-update
Cc: mcs, brade, gk, mrphs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

mrphs discovered that the font whitelist after the updater ran didn't get properly applied until restarting Tor Browser.

I also saw another pref not update this morning (I think it was "dom.event.highrestimestamp.enabled") when my TBB updated. (Though I may be misremembering.)

So it would be useful to figure out if prefs are not getting fully applied until the browser restarts after an update. Is this a Firefox problem or just TBB? It could potentially be a significant security/privacy flaw.

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by gk

Cc: mcs brade gk added

comment:2 Changed 4 years ago by mcs

I am not sure what is going on. Only one restart should be required. How did mrphs fix the whitelist problem? Can someone provide a reproducible test case?

While discussing this ticket with me, Kathy pointed out that changes made to Linux the start up script will not go in effect until that script is re-run, which does not happen during a "restart after update." I am not sure how to easily fix that, but it will prevent the FONTCONFIG_PATH/FONTCONFIG_FILE env variable changes made for #16672 from taking effect until a full "exit/start again" kind of restart is done.

comment:3 in reply to:  2 Changed 4 years ago by arthuredelstein

Cc: mrphs added

Replying to mcs:

I am not sure what is going on. Only one restart should be required. How did mrphs fix the whitelist problem? Can someone provide a reproducible test case?

mrphs fixed the whitelist problem by restarting Tor Browser (on OS X). So far I'm not able to reproduce the problem I described, which makes me wonder if my diagnosis is incorrect. mrphs, I remember you mentioning that your auto-update failed in some way. Can you give more details -- what error did you see and how did you finally get update to work? Did you ever press "Restart later"?

While discussing this ticket with me, Kathy pointed out that changes made to Linux the start up script will not go in effect until that script is re-run, which does not happen during a "restart after update." I am not sure how to easily fix that, but it will prevent the FONTCONFIG_PATH/FONTCONFIG_FILE env variable changes made for #16672 from taking effect until a full "exit/start again" kind of restart is done.

This is a good point -- if possible I would like to move that FONTCONFIG stuff out of environment variables and into a new Linux whitelisting patch, but I haven't figured out if that's possible yet.

comment:4 Changed 20 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:5 Changed 6 months ago by gk

Keywords: tbb-updater added

comment:6 Changed 6 months ago by gk

Keywords: tbb-update added; tbb-updater removed

Renaming keyword to make it a bit broader

Note: See TracTickets for help on using tickets.