Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#1715 closed enhancement (wontfix)

Remove old unused win code.

Reported by: mingw-san Owned by: nickm
Priority: Medium Milestone:
Component: Core Tor/Tor Version: Tor: 0.2.2.14-alpha
Severity: Keywords: Windows DNS
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After 8d31141ccbdbeee9589d04ea99819af7aa35193b no more chance for non WinNT platforms. Moreover no was chances for dns stuff. Guess CE have more Tor users than 9x/Me.
--- eventdns.c.was Tue May 25 04:57:58 2010
+++ eventdns.c Tue Jul 20 13:00:56 2010
@@ -3227,7 +3227,6 @@

}


#define SERVICES_KEY L"System
CurrentControlSet
Services
"

-#define WIN_NS_9X_KEY SERVICES_KEY L"VxD
MSTCP"

#define WIN_NS_NT_KEY SERVICES_KEY L"Tcpip
Parameters"


static int

@@ -3269,16 +3268,6 @@

TRY(interfaces_key, "DhcpNameServer");
RegCloseKey(interfaces_key);
RegCloseKey(nt_key);

  • } else {
  • HKEY win_key = 0;
  • if (RegOpenKeyExW(HKEY_LOCAL_MACHINE, WIN_NS_9X_KEY, 0,
  • KEY_READ, &win_key) != ERROR_SUCCESS) {
  • log(EVDNS_LOG_DEBUG, "Couldn't open registry key, %d", (int)GetLastError());
  • return -1;
  • }
  • TRY(win_key, "NameServer");
  • RegCloseKey(win_key);
  • }


if (found == 0) {

log(EVDNS_LOG_WARN,"Didn't find any nameservers.");

Amen.

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by nickm

Owner: set to nickm
Status: newassigned

I don't think we knew that Win95/98 was working _before_ 8d31141ccbdbe. It certainly wasn't intentional to break them; I have no idea if there are still any out there. If you want to get them working again without breaking WinCE, that would be fine.

Otherwise, I'd rather wait for another release or two before merging this code, to assess whether we still have any win98 users left who care that Tor broke. If nobody complains, let's go ahead and admit that we really do require a NT.

comment:2 Changed 9 years ago by mingw-san

As for suggested patch, it's a slightly broken, there are one extra line was deleted in the patch, good it's waitable for next after next release :)

Tor have been worked for Win98 platform almost all times (with exceptions for aplha-s while nt service was inroduced at first time for some years ago) if it was compiled with mingw port of gcc. Now it reqires unicode funcs support with no luck for 9x.

comment:3 Changed 9 years ago by nickm

So, the logical thing to do then would be to allow either unicode or non-unicode compilation of Tor. I'd love a patch to fix that.

comment:4 Changed 9 years ago by nickm

Resolution: wontfix
Status: assignedclosed

Closing this bug; opening a "Fix Windows non-Unicode builds" bug as #1797.

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.