Opened 4 years ago

Closed 3 years ago

#17153 closed defect (fixed)

tor test networks should allow IPv6 private addresses

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.3.16-alpha
Severity: Normal Keywords: testing, 028-triaged, ipv6, easy
Cc: Actual Points:
Parent ID: #17811 Points: small
Reviewer: Sponsor: SponsorS

Description

net/nodes/003br/notice.log:Sep 25 09:42:34.000 [warn] Unable to use configured IPv6 address "[::1]" in a descriptor. Skipping it. Try specifying a globally reachable address explicitly.

I'm sure there's a tor option that allows private addresses in descriptors for IPv4. It should do that for IPv6 as well.

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:2 Changed 4 years ago by nickm

Keywords: SponsorS removed
Sponsor: SponsorS

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

comment:3 Changed 4 years ago by nickm

Points: small

comment:4 Changed 3 years ago by teor

Keywords: ipv6 added
Parent ID: #17011#17811
Severity: Normal

comment:5 Changed 3 years ago by teor

Keywords: easy added
Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

This would be nice in 0.2.8, but I'm not sure if it's going to make it.

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.9.x-finalTor: 0.2.8.x-final
Status: newneeds_review
Version: Tor: unspecifiedTor: 0.2.3.16-alpha

Please see my branch bug17153 in https://github.com/teor2345/tor.git which changes the IPv6 address check in the descriptor code to match the IPv4 address check.

Putting in 0.2.8 because it's a trivial fix based on the existing IPv4 code, which we need to test IPv6 in test networks.

comment:7 Changed 3 years ago by karsten

I confirm that your bug17153 branch, commit 2120e14 fixes my problem with running Chutney's bridges+ipv6 network configuration. Thanks a lot!

comment:8 Changed 3 years ago by nickm

Looks okay to me too. I don't love the way that this does the same check in two places though; opening another ticket for that.

comment:9 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; opened #18529 for the refactor issue.

Note: See TracTickets for help on using tickets.