Opened 4 years ago

Last modified 2 years ago

#17197 new defect

Use CRLF for all text files written on Windows, accept either CRLF or LF on all platforms

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client tor-relay win32 windows
Cc: Actual Points:
Parent ID: Points: medium
Reviewer: Sponsor:

Description

In #17501, stem becomes confused because some text files written on Windows use CRLF, and others use LF.

We could use CRLF for all text files written on Windows, and accept either CRLF or LF on all platforms.

Here is a list of files from DataDirectory with their line endings on Windows:

CRLF cached-certs
CRLF cached-consensus
LF   cached-descriptors
LF   cached-descriptors.new
CRLF cached-microdesc-consensus
LF   cached-microdescs
LF   cached-microdescs.new
CRLF state

We might want to review all files written by tor, including those only written by hidden services and any other components.

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by nickm

Points: medium
Priority: normalminor

comment:2 Changed 3 years ago by nickm

Severity: Normal

This isn't completely trivial -- for some of these, we want to be able to mmap them. For most, we need byte-by-byte accuracy so that signature checking and digest computations work out right.

comment:3 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

Move a bunch of (but not all) low-priority items to 0.2.???. If you write a patch, it can still get into 0.2.8

comment:4 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:5 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:7 Changed 2 years ago by nickm

Keywords: tor-client tor-relay win32 windows added
Note: See TracTickets for help on using tickets.