Opened 4 years ago

Closed 4 years ago

#17255 closed defect (fixed)

get_ifaddrs_* unti tests assume an IPv4 address is configured

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7.3-rc
Severity: Keywords: tests
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

get_ifaddrs_* unti tests assume an IPv4 address is configured, but when my Wifi is off, that isn't true.

It's best not to assume much, so the tor unit tests can run on networkless boxes.

This needs a backport to 0.2.7.

Child Tickets

Change History (2)

comment:1 Changed 4 years ago by teor

Status: newneeds_review

See my branch fix-ifaddr-unit-tests-v2 at https://github.com/teor2345/tor.git for a fix to this issue.

comment:2 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

cherry-picked to 0.2.7.

Note: See TracTickets for help on using tickets.