Opened 5 years ago

Closed 5 years ago

#17269 closed defect (implemented)

Draft process to ensure tickets and proposals get reviewed

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: process, 201511-deferred, TorCoreTeam201601, 201512-deferred
Cc: Actual Points:
Parent ID: Points: medium
Reviewer: Sponsor:


Our current process doesn't do much to provide a deadline by which people can expect that their patches will be reviewed. It also doesn't push proposals towards an up/down resolution.

We need to make changes in this area, since having a bunch of "needs_review" items sticking around is bad for getting volunteers online and making Tor better.

Target: Nov 2015.

Child Tickets

Change History (7)

comment:1 Changed 5 years ago by nickm

Keywords: TorCoreTeam201511 added

comment:2 Changed 5 years ago by nickm

Keywords: TorCoreTeam201512 201511-deferred added; TorCoreTeam201511 removed

Bulk-move uncompleted items to december. :/

comment:3 Changed 5 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 5 years ago by nickm

Severity: Normal

At least the following proposals have been floated:

  • Get more submaintainers for subcomponents!
  • Dedicate a given fraction of each week or month to review. (Eg, "on monday, review only, if there's anything to review.")
  • Try to prioritize tickets for review
  • Make a ticket for the review of each open proposal.
  • Assign tickets to people.
  • Regular design review/proposal update segments at or independent of tor dev meetings.

[Summarizing here so I can remove the email thread from my inbox]

comment:5 Changed 5 years ago by nickm

Keywords: TorCoreTeam201601 201512-deferred added; TorCoreTeam201512 removed

Perhaps in January?

comment:6 Changed 5 years ago by nickm

14:00 < nickm> I suggest that everybody takes their two or three favorite 
               proposals that they didn't write, and nominates them, and we 
               have some proposal discussion sessions with meetbot on IRC where 
               everybody shows up having read the propsal and ready to talk 
               about it, trying to move it towards "Rejected" or "Accepted".
14:01 < nickm> we should explicitly send links to these sessions to tor-dev for 
               others to comment on, since proposal transparency is really 
14:01 < nickm> I'm thinking at least one session like that per week for a while 
               until we have less backlog.
14:01 < nickm> what do folks think about that?

comment:7 Changed 5 years ago by nickm

Resolution: implemented
Status: acceptedclosed

Did this for proposals with an email I just sent to tor-dev:

Note: See TracTickets for help on using tickets.