Split up controller.py's integ tests

Our integ tests are subdivided by module. Generally this is well and good, but since we're a controller library that means a disproportionate number of tests have... well, been for the controller.

We should further break this up. One thought would be by controller functionality...

• getinfo commands
• tor config options (GETCONF, SETCONF)
• event handling
• hidden services
• ... etc...

added component::archived/stem easy owner::atagar priority::low resolution::worksforme severity::normal status::closed testing type::enhancement labels

I have not made all changes listed, but I have split the getinfo commands into separate commands as in this patch:

https://gist.github.com/neelchauhan/2e76169143dc6e24ef69321fcd6d68fb

Let me know if there are any issues with this patch.

Also, the testing log is posted here:

https://gist.github.com/neelchauhan/7b032d05083e85f52d31241a8999700e

Thanks, Neel Chauhan

https://www.neelc.org/

Trac:
Severity: N/A to Normal
Reviewer: N/A to N/A

Thanks Neel! This ticket is pretty old and since then I've had time to think about a good alternate way to structure our tests. Rather than breaking up test functions think we should aim for the test modules so they relate to a single class or topic. That is to say instead of...

class TestController(unittest.TestCase):
  ... tests everything...

... we have...

class TestControllerCommands(unittest.TestCase):
  ... tests GETINFO, GETCONF, etc...

class TestHiddenServices(unittest.TestCase):
  ... tests hidden service functions...

There could be merit to breaking up the functions as you did here too.

Trac:
split_classes.patch

Patch to split controller.py integration tests

Trac:
integ_test.txt

Logfile for testing the integration tests

I have created new attachments where the classes for the integration test were split. Keep in mind that:

• This patch does not have the getinfo commands split. I may do it in another patch.
• In the integration test output, I get control.controller multiple times.

Tell me what you think about this patch.

Thanks, Neel Chauhan

Hmmm, now that I see what this looks like maybe this wasn't such a great idea. Sorry about the dead end... :(

One thing in your testing output I'd very much like to correct are all those pyflakes issues. Just pushed a change that should deal with them. Mind giving it a whirl and seeing if you still get any warnings?

Trac:
integ_test.2.txt

Output of the integration test with the pycodestyle fixes

Think I'm gonna close this. Patches to improve our tests welcome but I'm unsure there's overly much need for this compared with some other testing maintainability improvements I can think of.

Trac:
Resolution: N/A to worksforme
Status: new to closed

closed