Opened 3 years ago

Last modified 2 months ago

#17343 new enhancement

Add torrc option OnionService* alias for HiddenService*

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs prop224-maybe torrc
Cc: dmr, s7r Actual Points:
Parent ID: #25918 Points:
Reviewer: Sponsor:

Description

Since the rebranding of Hidden Service to "Onion Service" is now a thing, it would make sense to add aliases for every hidden service torrc option to be changed to use "OnionService" instead. Here are the options I can find in tor man page:

HidServAuth --> OnionServiceAuth
HidServDirectoryV2 --> OnionServiceDirectoryV2
MinUptimeHidServDirectoryV2 --> MinUptimeOnionServiceDirectoryV2
VoteOnHidServDirectoriesV2 --> VoteOnOnionServiceDirectoriesV2
PublishHidServDescriptors --> PublishOnionServiceDescriptors
FetchHidServDescriptors --> FetchOnionServiceDescriptors

HiddenService* --> OnionService*

Just to be clear, it's NOT a renaming but we add an alias for the current options so both live together.

Child Tickets

Change History (14)

comment:1 Changed 3 years ago by cypherpunks

100% no, it would not. Unilaterally renaming hidden services is not going to happen.

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-final

comment:3 Changed 3 years ago by dgoulet

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???
Severity: Normal
Sponsor: None

Out of any reasonable milestone for now. Once we decide if good or not, we can set a goal that makes sense.

comment:4 Changed 3 years ago by nickm

Sponsor: None

Change Core Tor tickets with sponsor "None" to "", per our practice elsewhere. This will help sorting.

comment:5 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 21 months ago by nickm

Keywords: prop224? torrc added

comment:9 Changed 11 months ago by teor

Parent ID: #25918

#25918 is an umbrella ticket for the entire rename

comment:10 Changed 11 months ago by dmr

Cc: dmr added
Keywords: prop224-maybe added; prop224? removed

Minor: prop224-maybe seems like a better convention for the keyword

comment:11 Changed 11 months ago by cypherpunks

HiddenService* --> OnionService*

Currently:
HiddenServiceVersion 3
HiddenService...

New:
OnionService...

(automatically set version to 3)

comment:12 in reply to:  11 Changed 11 months ago by teor

Replying to cypherpunks:

HiddenService* --> OnionService*

Currently:
HiddenServiceVersion 3
HiddenService...

New:
OnionService...

(automatically set version to 3)

No, aliases should mean exactly the same thing: anything else is confusing to users.

We have missed the opportunity to link the OnionService transition to version 3 onion services, because they came out in 0.3.2, which is stable and won't be getting new features or new options. (I don't know if we would make an exception for aliases.)

comment:13 Changed 11 months ago by nickm

I'm okay with backporting aliases.

comment:14 Changed 2 months ago by s7r

Cc: s7r added
Note: See TracTickets for help on using tickets.