rend_service_relaunch_rendezvous() ignores hs_service_requires_uptime_circ()

rend_service_introduce() sets CIRCLAUNCH_NEED_UPTIME in flags if rend_service_requires_uptime() is true.

But rend_service_relaunch_rendezvous() doesn't do this.

We should do the same thing in both places, or, better yet, we should refactor the code so it's shared.

changed milestone to %Tor: 0.4.1.x-final

added actualpoints::0.1 asn-merge component::core tor/tor milestone::Tor: 0.4.1.x-final owner::neel points::0.5 priority::medium resolution::fixed reviewer::dgoulet severity::normal status::closed tor-hs type::defect version::tor unspecified labels

Trac:
Summary: rend_service_relaunch_rendezvous() ignores rend_service_requires_uptime()_needs_uptime to rend_service_relaunch_rendezvous() ignores rend_service_requires_uptime()

Trac:
Sponsor: N/A to SponsorR

This could be seen as a feature rather than a bug - choosing from a wider pool of nodes means we're more likely to get a successful connection. If so, we should document it, rather than leaving it implicit.

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.9.x-final

Trac:
Reviewer: N/A to N/A
Sponsor: SponsorR to SponsorR-can

Trac:
Points: N/A to small/medium
Keywords: tor-hs deleted, tor-hs thought-needed added

tickets market to be removed from milestone 029

Trac:
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.???

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Keywords: tor-hs thought-needed deleted, tor-03-unspecified-201612, tor-hs, thought-needed added
Milestone: Tor: 0.3.??? to Tor: unspecified

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: thought-needed deleted, N/A added
Points: small/medium to 0.5
Sponsor: SponsorR-can to N/A

Trac:
Cc: N/A to dgoulet, asn

Trac:
Status: new to assigned
Cc: dgoulet, asn to dgoulet, asn, neel
Owner: N/A to neel

I believe rend_service_requires_uptime() was renamed to hs_service_requires_uptime_circ() and the former function no longer exists in Tor.

Trac:
Summary: rend_service_relaunch_rendezvous() ignores rend_service_requires_uptime() to rend_service_relaunch_rendezvous() ignores hs_service_requires_uptime_circ()

I have a GitHub PR here: https://github.com/torproject/tor/pull/739

Trac:
Status: assigned to needs_review

Trac:
Milestone: Tor: unspecified to Tor: 0.4.1.x-final

Trac:
Status: needs_review to needs_revision

I have moved the base32_encode() call into the if (!service) statement.

I could not move the rend_pk_digest() call into the statement because it's needed by rend_service_get_by_pk_digest() to fill in service which is needed by hs_service_requires_uptime_circ().

These changes have been pushed and I am setting this as needs review.

Trac:
Status: needs_revision to needs_review

Trac:
Reviewer: N/A to dgoulet

lgtm! Thanks neel yet again! :)

Trac:
Status: needs_review to merge_ready
Keywords: N/A deleted, asn-merge added

Merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

The changes file for this release said "bugfix on 0.4.0.2-alpha", but this is actually a bug on 0.1.0.1-rc. I fixed it in the ChangeLog and ReleaseNotes in #31461 (moved).

Trac:
Actualpoints: N/A to 0.1
Version: N/A to Tor: unspecified

closed

changed time estimate to 4h

added 48m of time spent

moved to tpo/core/tor#17357 (closed)