Opened 4 years ago

Closed 6 months ago

#17357 closed defect (fixed)

rend_service_relaunch_rendezvous() ignores hs_service_requires_uptime_circ()

Reported by: teor Owned by: neel
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, asn-merge
Cc: dgoulet, asn, neel Actual Points:
Parent ID: Points: 0.5
Reviewer: dgoulet Sponsor:

Description

rend_service_introduce() sets CIRCLAUNCH_NEED_UPTIME in flags if rend_service_requires_uptime() is true.

But rend_service_relaunch_rendezvous() doesn't do this.

We should do the same thing in both places, or, better yet, we should refactor the code so it's shared.

Child Tickets

Change History (20)

comment:1 Changed 4 years ago by teor

Summary: rend_service_relaunch_rendezvous() ignores rend_service_requires_uptime()_needs_uptimerend_service_relaunch_rendezvous() ignores rend_service_requires_uptime()

comment:2 Changed 4 years ago by dgoulet

Sponsor: SponsorR

comment:3 Changed 4 years ago by teor

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

This could be seen as a feature rather than a bug - choosing from a wider pool of nodes means we're more likely to get a successful connection. If so, we should document it, rather than leaving it implicit.

comment:4 Changed 3 years ago by dgoulet

Sponsor: SponsorRSponsorR-can

comment:5 Changed 3 years ago by nickm

Keywords: thought-needed added
Points: small/medium

comment:6 Changed 3 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:7 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:8 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:9 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:10 Changed 2 years ago by dgoulet

Keywords: thought-needed removed
Points: small/medium0.5
Sponsor: SponsorR-can

comment:11 Changed 2 years ago by nickm

Cc: dgoulet asn added

comment:12 Changed 6 months ago by neel

Cc: neel added
Owner: set to neel
Status: newassigned

comment:13 Changed 6 months ago by neel

Summary: rend_service_relaunch_rendezvous() ignores rend_service_requires_uptime()rend_service_relaunch_rendezvous() ignores hs_service_requires_uptime_circ()

I believe rend_service_requires_uptime() was renamed to hs_service_requires_uptime_circ() and the former function no longer exists in Tor.

comment:14 Changed 6 months ago by neel

Status: assignedneeds_review

comment:15 Changed 6 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.1.x-final

comment:16 Changed 6 months ago by dgoulet

Status: needs_reviewneeds_revision

comment:17 Changed 6 months ago by neel

Status: needs_revisionneeds_review

I have moved the base32_encode() call into the if (!service) statement.

I could not move the rend_pk_digest() call into the statement because it's needed by rend_service_get_by_pk_digest() to fill in service which is needed by hs_service_requires_uptime_circ().

These changes have been pushed and I am setting this as needs review.

comment:18 Changed 6 months ago by asn

Reviewer: dgoulet

comment:19 Changed 6 months ago by dgoulet

Keywords: asn-merge added
Status: needs_reviewmerge_ready

lgtm! Thanks neel yet again! :)

comment:20 Changed 6 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.