Opened 9 years ago

Closed 9 years ago

#1737 closed enhancement (implemented)

TorCtl Feature Addition

Reported by: atagar Owned by: mikeperry
Priority: Medium Milestone:
Component: Torctl Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Moving this to trac as per Mike's request.

Arm has a few helper functions in its util package that would be a nice addition for TorCtl. In particular, there's...

  • connect (along with makeCtlConn and initCtlConn) to fetch PROTOCOLINFO and handle the authenticating (I'm finding this to be very handy for scripts and for quickly getting a TorCtl instance in the interactive interpretor to experiment with)
  • getPid (I know orbot has similar functionality for Java and suspecting this would be of interest to other controllers)

Functions are currently available in 'https://svn.torproject.org/svn/arm/trunk/util/torTools.py'. If something needs to be revised to be a better fit then let me know. Cheers! -Damian

Child Tickets

Attachments (1)

0001-Convenience-functions-for-creating-and-authenticatin.patch (8.0 KB) - added by atagar 9 years ago.
git patch for torctl creating/authenticating convenience functions

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by atagar

Owner: set to mikeperry
Status: newassigned

Changed 9 years ago by atagar

git patch for torctl creating/authenticating convenience functions

comment:2 Changed 9 years ago by atagar

Since there's a proposal for adding the pid functionality to tor we might as well skip adding it to TorCtl. The other functions, however, would still be very useful. See attached for a patch of the addition. Cheers! -Damian

comment:3 Changed 9 years ago by atagar

Status: assignedneeds_review

comment:4 Changed 9 years ago by atagar

Resolution: implemented
Status: needs_reviewclosed

A revised patch has been merged with commit '6a2885fa4f517c74ec0a79ee22a5333dc3a87b0f'. Thanks! Resolving.

Note: See TracTickets for help on using tickets.