Opened 5 years ago

Closed 5 years ago

#17383 closed defect (fixed)

rsync hang in Gitian bundling step

Reported by: gk Owned by: gk
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-gitian, TorBrowserTeam201510R
Cc: ln5, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

ln5 just got his nightly build to hang in the 64 bit Linux bundling step. The reason is similar to #10153: libfaketime is interfering with the inner rsync workings in a bad way. Might be easiest to just copy and paste the solution that excludes rsync from libfaketime's reach. This might be safer than not having libfaketime active when running makexpi.sh.

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by mcs

Cc: mcs added

comment:2 Changed 5 years ago by gk

Status: new → needs_review

bug_17383_v2 (​https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_17383_v2&id=246c96b8ed02b52f44fe2d5eaf0246038b12f3d4) in my public tor-browser-bundle repo has a fix up for review.

comment:3 Changed 5 years ago by gk

Keywords: TorBrowserTeam201510R added; TorBrowserTeam201510 removed

comment:4 Changed 5 years ago by mcs

r=mcs
I did not test this fix, but the patch looks good to me.

comment:5 Changed 5 years ago by ln5

make build-nightly worked fine with this fix applied.

comment:6 Changed 5 years ago by gk

Resolution: → fixed
Status: needs_review → closed

Thanks, applied to master (commit 246c96b8ed02b52f44fe2d5eaf0246038b12f3d4).

Note: See TracTickets for help on using tickets.