Opened 4 years ago

Closed 3 years ago

#17424 closed defect (fixed)

Improve GetTor Links

Reported by: sukhbir Owned by: ilv
Priority: Medium Milestone:
Component: Applications/GetTor Version:
Severity: Normal Keywords:
Cc: mrphs, ilv Actual Points:
Parent ID: #9036 Points:
Reviewer: Sponsor:

Description

We have three providers currently: Dropbox, Google Drive, GitHub.

The current link formatting in the GetTor reply looks like:

Tor Browser 32/64-bit:
https://raw.githubusercontent.com/...
https://www.dropbox.com/...
https://docs.google.com/...

We should try to make this better. At the minimum, we should tell the user which provider the links refer to so that they can choose without having to guess from the URLs.

Child Tickets

Attachments (1)

0001-Indent-links-text-in-message-body-see-17424-comment-.patch (764 bytes) - added by sukhbir 4 years ago.
I just pushed (2) to develop and for (4), I am attaching the patch since you should review before pushing it.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by ilv

I agree. I think we could solve this simply by doing:

Tor Browser 32/64-bit:

Download from Github: https://raw.githubusercontent.com/...
Download from Dropbox: https://www.dropbox.com/...
Download from Google Drive: https://docs.google.com/...

So every time we add a new provider we just add a new line. This way, IMO, we keep the message simple and we give enough information to the end user. We could use the sentences: "Download from $PROVIDER: ", "From $PROVIDER: ", or just "$PROVIDER: ". One possible problem with the first two is that the links are quite long, so each line will get even longer; not sure how important is this though.

Thoughts?

comment:2 in reply to:  1 Changed 4 years ago by sukhbir

Replying to ilv:

I agree. I think we could solve this simply by doing:
Thoughts?

Yeah I had something similar in mind. Building on the other text, how about we remove the "download from" to save space since that is obvious in a way:

You requested Tor Browser for $PLATFORM.

You will need only one of the links below to download the bundle. If a link
does not work for you, try the next one.

    GitHub: <link>
    Dropbox: <link>
    Google Drive: <link>

comment:3 Changed 4 years ago by ilv

Sounds good to me!

comment:4 Changed 4 years ago by ilv

Changes here.

comment:5 Changed 4 years ago by sukhbir

Thanks for merging the changes and the other improvements you did! Looks great!

Some minor nitpicking; open for discussion:

  1. For the reply for windows, it says:

Tor Browser 32/64-bit:

Should we just say Tor Browser here?

  1. Signature
All the best.
--
GetTor team

I am not averse to the idea but let's keep the text body as minimal as possible. What do you think?

  1. It says Drive. Should we change it to Google Drive instead?
  1. Perhaps we can tab/indent the links or do you prefer them like this?

Happy to submit patches for all above if you agree!

comment:6 in reply to:  5 ; Changed 4 years ago by ilv

Some minor nitpicking; open for discussion:

  1. For the reply for windows, it says:

Tor Browser 32/64-bit:

Should we just say Tor Browser here?


Yes, probably. For the moment this is not so easy to change, because this text is generated by gettor.core while getting the links. Thing is, we should change that in the near future (I also thought of this while working on the RESTful API). Once we do that we could improve what you mention. Maybe we could open a separate ticket for it so we don't forget about it?

  1. Signature
All the best.
--
GetTor team

I am not averse to the idea but let's keep the text body as minimal as possible. What do you think?


I think we should keep at least the GetTor team (or GetTor, GetTor robot) part, so the email doesn't seem to end abruptly after the links.

  1. It says Drive. Should we change it to Google Drive instead?


Yes, that is just a matter of configuration in the drive.links. It says Google Drive now.

  1. Perhaps we can tab/indent the links or do you prefer them like this?


Sounds good to me.

Happy to submit patches for all above if you agree!


Good! could you submit patches for 2 and 4?

comment:7 in reply to:  6 Changed 4 years ago by sukhbir

Replying to ilv:

Yes, probably. For the moment this is not so easy to change, because this text is generated by gettor.core while getting the links. Thing is, we should change that in the near future (I also thought of this while working on the RESTful API). Once we do that we could improve what you mention. Maybe we could open a separate ticket for it so we don't forget about it?

Let's go with it for now and we can revisit this later.

  1. Signature
All the best.
--
GetTor team

I am not averse to the idea but let's keep the text body as minimal as possible. What do you think?


I think we should keep at least the GetTor team (or GetTor, GetTor robot) part, so the email doesn't seem to end abruptly after the links.

OK. Agreed.

  1. It says Drive. Should we change it to Google Drive instead?


Yes, that is just a matter of configuration in the drive.links. It says Google Drive now.

Great!

  1. Perhaps we can tab/indent the links or do you prefer them like this?


Sounds good to me.

Happy to submit patches for all above if you agree!


Good! could you submit patches for 2 and 4?

Will push (2) and (4) to develop.

Changed 4 years ago by sukhbir

I just pushed (2) to develop and for (4), I am attaching the patch since you should review before pushing it.

comment:8 Changed 3 years ago by ilv

Sorry, I forgot about this. The patch doesn't add indentation for the links, so I didn't applied it. However, I added indentation here. I also applied these same changes to the messages sent by the xmpp and twitter bots (see this). I think we are done with this ticket.

comment:9 Changed 3 years ago by ilv

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.