Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#1747 closed defect (fixed)

Update rend-spec.txt to cover hidden service authentication

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Sebastian, koryk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

rend-spec.txt right now doesn't say anything about hidden service authentication as specified in proposal 121. We should update it.

Child Tickets

Change History (14)

comment:1 Changed 9 years ago by karsten

Cc: Sebastian added
Status: newneeds_review

See branch rendspec in my public repo.

comment:2 Changed 9 years ago by nickm

Looks okay, but doesn't apply cleanly to master.

comment:3 Changed 9 years ago by karsten

Sebastian asked why this patch is based on maint-0.2.1, not master. ChangeLog says that proposal 121 was implemented in 0.2.1.6-alpha. That's why I used maint-0.2.1 as the basis.

Now, the new rend-spec.txt has references to 0.2.2.1-alpha, saying that we deprecated v0 descriptors in that version. If that is a problem, I can rebase the patch to master.

comment:4 Changed 9 years ago by Sebastian

I would prefer the patch on master. It doesn't make sense to update the spec in stable, imo

comment:5 Changed 9 years ago by Sebastian

Other than that, I like it.

comment:6 Changed 9 years ago by karsten

See branch rendspec-master in my public repository.

comment:7 Changed 9 years ago by Sebastian

On second thought, this wants a changes file before we merge. Please add that?

comment:8 in reply to:  7 Changed 9 years ago by Sebastian

Replying to Sebastian:

On second thought, this wants a changes file before we merge. Please add that?

wrong bugreport -.-

comment:9 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Great; merged. Thanks!

comment:10 Changed 9 years ago by karsten

Cc: koryk added
Resolution: fixed
Status: closedreopened

koryk has some more corrections to rend-spec.txt that I put in branch rendspec-koryk in my public repository. Kory, I tweaked your changes a bit. Please have a look.

comment:11 Changed 9 years ago by nickm

Status: reopenedneeds_review

Looks okay to me if Kory likes your changes.

comment:12 Changed 9 years ago by karsten

Hmmm, no reply from Kory... How about we merge these changes now and make another commit if Kory shows up and doesn't like this one? Most of these are minor changes anyway.

comment:13 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Done; thanks.

comment:14 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.