Opened 4 years ago

Closed 4 years ago

#17502 closed enhancement (fixed)

Add option for suppressing the "Open with" option in the download dialog

Reported by: anonym Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: AffectsTails, TorBrowserTeam201512R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There should be a way to disable the "Open with" option in the download dialog since it is not working (and hence confusing) when sandboxing (e.g. AppArmor) prevents the Tor Browser from starting external applications. See this tbb-dev@ thread and this Tails ticket for the full story.

Child Tickets

Attachments (1)

0001-Add-a-pref-hiding-the-Open-with-option-in-the-downlo.patch (2.3 KB) - added by anonym 4 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by anonym

Status: newneeds_review

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201511R added

comment:3 Changed 4 years ago by gk

Status: needs_reviewneeds_revision

firefox.js is the wrong file for this preference. Could you add it to 000-tor-browser.js probably below pref("devtools.debugger.chrome-debugging-host", "127.0.0.1"); and add a comment explaining a bit what it does?

comment:4 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201512R added; TorBrowserTeam201511R removed

comment:5 Changed 4 years ago by gk

Resolution: fixed
Status: needs_revisionclosed

Okay, I went ahead and made the changes I had in mind as a fixup commit (721f255ca93675c6a3caf2e75678978c8a4db72c) on-top of the patch (c3aafe32d28271e04b616eaf92f826fc70c4627a) on tor-browser-38.4.0esr-5.5-1; I applied both to the stable branch as well.

Note: See TracTickets for help on using tickets.