#17548 closed defect (fixed)
https://bridges.torproject.org/keys shows outdated keys
| Reported by: | gk | Owned by: | phw |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Circumvention/BridgeDB | Version: | |
| Severity: | Normal | Keywords: | ex-sponsor-19, s30-o22a2 |
| Cc: | Actual Points: | 0.5 | |
| Parent ID: | #31279 | Points: | 1 |
| Reviewer: | cohosh | Sponsor: | Sponsor30-can |
Description (last modified by )
While looking at https://bridges.torproject.org/keys that the online keys expired 2015-09-11. It seems the document needs an update. And s/will will not/will not/.
Child Tickets
Change History (16)
comment:1 Changed 5 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 17 months ago by
comment:3 Changed 17 months ago by
| Owner: | isis deleted |
|---|---|
| Points: | → 1 |
| Sponsor: | → Sponsor19 |
| Status: | new → assigned |
comment:4 Changed 17 months ago by
another approach besides updating the key might be to figure out what the key is actually used for, notice that it hasn't been working for three+ years and nobody minded, and change the design to not need this key anymore.
comment:5 Changed 12 months ago by
| Keywords: | ex-sponsor-19 added |
|---|
Adding the keyword to mark everything that didn't fit into the time for sponsor 19.
comment:6 Changed 12 months ago by
| Sponsor: | Sponsor19 → Sponsor30-can |
|---|
Moving from Sponsor 19 to Sponsor 30.
comment:7 Changed 7 months ago by
BridgeDB is (or was) able to sign its email distributor's responses. As far as I can tell, the feature no longer works. I suggest to remove the feature: it's quite a bit of complexity that currently serves no purpose. If somebody ever wants to resurrect it, it will still be part of our commit log.
comment:8 Changed 7 months ago by
For what it's worth, BridgeDB's log files suggest that it occasionally gets requests for the PGP keys. This happened several times in today's logs. We should spend one or two hours trying to figure out if we can update these keys.
comment:9 Changed 3 months ago by
| Status: | assigned → new |
|---|
Change tickets that are assigned to nobody to "new".
comment:10 Changed 7 weeks ago by
| Status: | new → needs_review |
|---|
Here's a patch that rips out PGP support: https://github.com/NullHypothesis/bridgedb/compare/develop...defect/17548?expand=1
comment:11 Changed 7 weeks ago by
| Owner: | set to phw |
|---|---|
| Status: | needs_review → assigned |
comment:12 Changed 6 weeks ago by
| Owner: | changed from phw to cohosh |
|---|
comment:14 follow-up: 15 Changed 6 weeks ago by
| Status: | assigned → merge_ready |
|---|
This looks good. Just a two comments:
- there's still a test with a gpg key request in it here
- the README should be updated as well: https://github.com/NullHypothesis/bridgedb/tree/defect/17548#gnupg-email-signing
comment:15 Changed 6 weeks ago by
| Actual Points: | → 0.5 |
|---|---|
| Keywords: | s30-o21a2 added |
| Parent ID: | → #31279 |
| Resolution: | → fixed |
| Status: | merge_ready → closed |
Replying to cohosh:
- there's still a test with a gpg key request in it here
Right, removed!
- the README should be updated as well: https://github.com/NullHypothesis/bridgedb/tree/defect/17548#gnupg-email-signing
Oops, I forgot about the README. Thanks! In fact, I also forgot to remove the .gnupg directory and the gnupg dependency in .travis.requirements.txt and requirements.txt.
I merged the branch in commit 4cdd6a6 and deployed it on polyanthum.
comment:16 Changed 3 weeks ago by
| Keywords: | s30-o22a2 added; s30-o21a2 removed |
|---|
Closed #20498 as a dupe