Opened 5 years ago

Last modified 5 months ago

#17584 new defect

Disable bookmark backups (easy fix) (!)

Reported by: cypherpunks Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-easy, tbb-torbutton, gitlab-tb-torbutton
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Tor browser shouldn't backup bookmarks at all and even when bookmarks are deleted, old backups remain in:


Child Tickets

Change History (11)

comment:1 Changed 5 years ago by cypherpunks

Component: - Select a componentTor Browser
Owner: set to tbb-team

comment:2 Changed 4 years ago by cypherpunks

Priority: MediumHigh

Wanted to create a ticket for this as well, bumping instead, deleted bookmarks should not be kept without the user knowing it is kept.

I often delete bookmarks I don't consider relevant anymore, but knowing they're being backed up in Browser/TorBrowser/Data/Browser/profile.default/bookmarkbackups forces me to check that folder every few days and purge it.

EDIT: Can be disabled by setting browser.bookmarks.max_backups to 0 in about:config

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:3 Changed 4 years ago by cypherpunks

Summary: Disable bookmark backupsDisable bookmark backups (easy fix) (!)
Type: defectenhancement

comment:4 Changed 4 years ago by cypherpunks

Type: enhancementdefect

What? Deleted bookmarks remain stored in "bookmarkbackups", why?

I've changed "browser.bookmarks.max_backups" to "0" in "about:config" for myself, like the comment above me says.

Is there a reason that this has been ignored for over 7 months? I mean come on, please fix this soon!

Thanks =)

comment:5 Changed 4 years ago by gk

Keywords: tbb-easy added

Binding this pref change to the option to disable Private Browsing Mode in Tor Browser (Don't record browsing history or website data (enabled Private Browsing Mode)) seems the way to go here. Patches are welcome!

comment:6 Changed 4 years ago by gk

Keywords: tbb-torbutton added

comment:7 Changed 4 years ago by cypherpunks

I'm not convinced that disabling bookmark backups is a good idea, but it might make sense to reduce the number of backups that are kept by default. It is entirely possible that the SQLite database can get corrupted, and if you're not manually backing up your bookmarks, you'd lose of all of them.

Tying this to private browsing mode doesn't make any sense to me, because bookmarks are kept regardless of this setting.

comment:8 Changed 9 months ago by sysrqb

Closed #32988 as dupe (?).

comment:9 Changed 7 months ago by bduszel

Hello everyone, just joined and would like to contribute to the project.

Is this defect still valid? It's pretty old but marked as an "easy fix" so I could start my journey with it.

comment:10 Changed 7 months ago by Thorin

I can see how up to 15 (default) days of daily bookmark backups could be an issue: assuming your device was compromised: i.e old bookmarks recently deleted would have a persistent disk write for the duration, but what if a user needs to restore them. I also think if your device was compromised, you would have more serious issues than this.

That said, I'm not totally against it: but maybe changing the default value to 2 or 3 might be a better compromise: at least a value of 1 gives a user a chance to instantly retrieve something

I haven't tested anything: so I'm not sure if changing the value removes old ones on a daily basis until it catches up, or if they persist

comment:11 Changed 5 months ago by sysrqb

Keywords: gitlab-tb-torbutton added
Note: See TracTickets for help on using tickets.