Opened 5 years ago

Closed 5 years ago

#17589 closed enhancement (implemented)

Decouple connection_dir_request_failed() from directory_initiate_command_rend()

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: blob SponsorS refactor
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Instead of calling connection_dir_request_failed() directly, directory_initiate_command_rend() should mark the failed connection and have it cleaned up later. This would prevent recursive invocation of directory_initiate_command_rend(), and remove 12 functions from the Blob.

I'd do this right now, but I want to test that the code actually does the right thing.

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by nickm

Type: defectenhancement

comment:2 Changed 5 years ago by nickm

Priority: LowMedium
Status: newneeds_review

My very small branch decouple_dir_request_failed makes this change. I have tested it by running as a server with random fault-injection code stuffed into connection_connect().

comment:3 Changed 5 years ago by andrea

This one looks fine to merge.

comment:4 Changed 5 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged; thanks Andrea!

Note: See TracTickets for help on using tickets.