Opened 4 years ago

Last modified 3 months ago

#17640 assigned enhancement

Handle CREATE/CREATED cell processing gracefully under load.

Reported by: yawning Owned by: yawning
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, scaling, tor-dos, tor-relay
Cc: asn Actual Points:
Parent ID: Points: 6
Reviewer: Sponsor: Sponsor27-can

Description

Two issues tangentially related in that both are for handling CPU worker backlog.

We currently sort of have logic for managing the CREATE processing backlog (see: have_room_for_onionskin), but behavior can be improved (I don't think the aging code actually gets called when we are under extreme backlog since we give up and drop before we age).

With my proposed #13737 branch, we will now additionally have to contend with CREATED backlog. I will probably opt for similar behavior to CREATED processing (opting to destroy the circuit if the backlog grows too large), but am open to hearing ideas for other options.

Child Tickets

Change History (19)

comment:1 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

comment:2 Changed 3 years ago by isabela

Sponsor: SponsorU-can

comment:3 Changed 3 years ago by nickm

Points: medium

comment:4 Changed 3 years ago by dgoulet

Cc: dgoulet removed
Owner: set to yawning
Status: newassigned
Version: Tor: unspecified

comment:5 Changed 3 years ago by mikeperry

Keywords: tor-dos added; dos removed

Canonicalize dos tag to tor-dos

comment:6 Changed 3 years ago by isabela

Points: medium3

comment:7 Changed 3 years ago by nickm

Parent ID: #17293

comment:8 Changed 3 years ago by yawning

Keywords: TorCoreTeam201608 added

comment:9 Changed 3 years ago by nickm

Keywords: nickm-deferred-20160905 added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

Hi, Yawning! I'm deferring these tickets assigned to you from 0.2.9 to 0.2.???, since you're going to be out for September. But if you wind up wanting to do any of them for 0.2.9 anyway, please feel free to move them back.

(This is my ticket-deferring afternoon)

comment:10 Changed 3 years ago by nickm

Parent ID: #17293

Unparenting these from #17293; holding for future work.

comment:11 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:12 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:13 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:14 Changed 2 years ago by nickm

Keywords: nickm-deferred-20160905 removed

comment:15 Changed 2 years ago by nickm

Keywords: TorCoreTeam201608 removed

comment:16 Changed 2 years ago by dgoulet

Keywords: tor-core removed

The tor-core keyword doesn't really make sense now that we have "Core Tor/Tor" for component.

comment:17 Changed 2 years ago by nickm

Keywords: tor-relay added

comment:18 Changed 2 years ago by nickm

Also see #17806.

comment:19 Changed 3 months ago by asn

Points: 36
Sponsor: SponsorU-canSponsor27-can
Note: See TracTickets for help on using tickets.