Opened 3 years ago

Last modified 22 months ago

#17665 new defect

Drop scheduler config options

Reported by: atagar Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Trivial Keywords: kist-related scheduler tor-relay kist-may-obsolete
Cc: pastly Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi Nick, the following tor configuration options were renamed in 2014 with a note saying they may go away...

* SchedulerLowWaterMark__
* SchedulerMaxFlushCells__
* SchedulerHighWaterMark__

Hidden options are prefixed with underscores (not suffixed). That said though no big whoop - can we drop them?

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-final

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

Move a bunch of (but not all) low-priority items to 0.2.???. If you write a patch, it can still get into 0.2.8

comment:3 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:5 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:6 Changed 22 months ago by nickm

Cc: pastly added
Keywords: kist-related scheduler tor-relay kist-may-obsolete added

comment:7 Changed 22 months ago by pastly

If we want to simplify the "vanilla" (current) scheduler with the merge of kist, these could certainly go away and either be replaced by #defines or simplifications of the scheduling loop logic. The behavior of the vanilla scheduler vs. the behavior implied by the code is very different, and these options are a big reason for that confusion.

Note: See TracTickets for help on using tickets.