Opened 4 years ago

Last modified 2 years ago

#17673 new defect

circuit_handle_first_hop assumes all one-hop circuits are directory circuits

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Minor Keywords: technical-debt tor-hs tor-client accident-waiting-to-happen
Cc: Actual Points:
Parent ID: #17692 Points: 1
Reviewer: Sponsor:

Description

I can't find an easy way to tell if a circuit is a directory circuit or a RSOS circuit. Do we need a type field?

if (circ->build_state->onehop_tunnel)
        control_event_bootstrap(BOOTSTRAP_STATUS_CONN_DIR, 0);

Child Tickets

Change History (13)

comment:1 Changed 4 years ago by nickm

That would make sense. Sometimes we use 'purpose' for this; another flag would be fine too.

comment:2 Changed 4 years ago by teor

Parent ID: #17178#17692

Make the review task the parent of this task.

comment:3 Changed 4 years ago by teor

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

Not critical for 0.2.8.

comment:4 Changed 3 years ago by nickm

Points: 1

comment:5 Changed 3 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:6 Changed 3 years ago by nickm

Keywords: nickwants029 added

I think teor wants this for rsos?

comment:7 in reply to:  6 Changed 3 years ago by teor

Keywords: teordoesntcare029 added
Priority: MediumLow
Severity: NormalMinor

Replying to nickm:

I think teor wants this for rsos?

Eventually. In the meantime, Single Onion Servers might get their bootstrap logging and control events a little out of order.

(But in almost every case, the first one-hop path will be a directory connection anyway, so I think we're ok here.)

comment:8 Changed 3 years ago by nickm

Keywords: nickwants029 removed

If teordoesntcare029, nickdoesntcareeither029

comment:9 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:10 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:11 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:12 Changed 2 years ago by nickm

Keywords: isaremoved removed

comment:13 Changed 2 years ago by nickm

Keywords: technical-debt tor-hs tor-client accident-waiting-to-happen added; teordoesntcare029 removed
Note: See TracTickets for help on using tickets.