Opened 4 years ago

Closed 4 years ago

#17683 closed defect (fixed)

Fail when TLS context fails to initialise

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy TorCoreTeam201512
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

+  log_info(LD_GENERAL,"Rotating tls context.");
+  if (router_initialize_tls_context() < 0) {
+    log_warn(LD_BUG, "Error reinitializing TLS context");
+    /* XXX is it a bug here, that we just keep going? -RD */
   }

I think it is - how about we assert() here, and see what happens?

Child Tickets

Attachments (1)

0001-Assert-when-the-TLS-contexts-fail-to-initialize.patch (1.1 KB) - added by cypherpunks 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by nickm

Agreed.

comment:2 Changed 4 years ago by teor

Keywords: easy TorCoreTeam201512 added

How to do this patch:

  • replace /* XXX is it a bug here, that we just keep going? -RD */ with tor_assert(0)
  • write a changes file

comment:3 Changed 4 years ago by nickm

Keywords: TorCoreTeam201512 removed

I'd look at a patch for these if we got one, but AFAIK nobody's looking at them right now, and there's no reason to expect them to get done this month.

comment:4 Changed 4 years ago by cypherpunks

Status: newneeds_review

Attached is patch for your consideration. It includes the suggested change and a changes file.

comment:5 Changed 4 years ago by teor

Keywords: TorCoreTeam201512 added

A one-line patch that does exactly what we asked for. With changes file!

Thanks, let's get this merged.

comment:6 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.