Opened 5 years ago

Closed 5 years ago

#17700 closed defect (fixed)

Check full SHA digests in unit tests

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201512
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The current test_crypto_sha unit test only checks the first 20 bytes of each digest. (The buffer sizes are somewhat out of whack, as we discovered in #17699.)

While it won't change the outcome of the tests, we really should check the entire length of each hash.

See my branch sha-unit-tests on https://github.com/teor2345/tor.git

Child Tickets

Change History (2)

comment:1 Changed 5 years ago by teor

Status: newneeds_review

comment:2 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

lgtm; merged!

Note: See TracTickets for help on using tickets.