#17702 closed defect (fixed)
Actually enable ed25519 collation.
Reported by: | nickm | Owned by: | nickm |
---|---|---|---|
Priority: | Very High | Milestone: | Tor: 0.2.8.x-final |
Component: | Core Tor/Tor | Version: | |
Severity: | Major | Keywords: | 027-backport, TorCoreTeam201602, must-fix-before-028-rc, 2016-bug-retrospective |
Cc: | Actual Points: | ||
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description
+ if (consensus_method < MIN_METHOD_FOR_ED25519_ID_VOTING + 10/*XXX*/)
I think this + 10
is debugging code.
Child Tickets
Change History (11)
comment:1 Changed 4 years ago by
Owner: | set to nickm |
---|---|
Priority: | High → Very High |
Status: | new → accepted |
comment:2 Changed 4 years ago by
Keywords: | TorCoreTeam201601 added |
---|
comment:3 Changed 4 years ago by
comment:4 Changed 4 years ago by
Possibly... Or possibly this is part of the issue behind that bug. Research needed!
comment:5 Changed 4 years ago by
Keywords: | 027-backport TorCoreTeam201601 → 027-backport, TorCoreTeam201601 |
---|
Bulk-modify: It is February 2016, and no longer possible that anything else will get done in January 2016. Time's arrow and all that.
comment:6 Changed 4 years ago by
Keywords: | TorCoreTeam201602 added; TorCoreTeam201601 removed |
---|
comment:7 Changed 4 years ago by
Milestone: | Tor: 0.2.8.x-final → Tor: 0.2.7.x-final |
---|---|
Status: | accepted → needs_review |
I have a patch for this as part of my branch ed25519_voting_fixes. I have run it through chutney, but should probably test it more thoroughly. I should also document it all in dir-spec.
comment:8 Changed 4 years ago by
Keywords: | must-fix-before-028-rc added |
---|---|
Milestone: | Tor: 0.2.7.x-final |
These are backportable, but they are tied to the 0.2.8 rc.
comment:9 Changed 4 years ago by
Milestone: | → Tor: 0.2.8.x-final |
---|
comment:10 Changed 4 years ago by
Resolution: | → fixed |
---|---|
Status: | needs_review → closed |
These are now merged into maint-0.2.7 and forwards.
comment:11 Changed 4 years ago by
Keywords: | 2016-bug-retrospective added |
---|
Marking these tickets (based on severity and hand-review) for inclusion in 2016 bug retrospective
Do we need to fix #17668 before deploying this?
(We were having trouble with votes containing conflicting ed25519 keys.)